Check if subject is available to avoid error in PropertyAccessor

BitScout · Aug 9, 2015 · 5c08def · 5c08def
1 parent a0801f1
commit 5c08def
Showing 1 changed file with 19 additions and 16 deletions.
diff --git a/Form/Type/AdminType.php b/Form/Type/AdminType.php
@@ -54,24 +54,27 @@ public function buildForm(FormBuilderInterface $builder, array $options)
         if ($builder->getData() === null) {
             $p = new PropertyAccessor(false, true);
             try {
-                // for PropertyAccessor < 2.5
-                // @todo remove this code for old PropertyAccessor after dropping support for Symfony 2.3
-                if (!method_exists($p, 'isReadable')) {
-                    $subjectCollection = $p->getValue(
-                        $admin->getParentFieldDescription()->getAdmin()->getSubject(),
-                        $this->getFieldDescription($options)->getFieldName()
-                    );
-                    if ($subjectCollection instanceof Collection) {
-                        $subject = $subjectCollection->get(trim($options['property_path'], '[]'));
+                $parentSubject = $admin->getParentFieldDescription()->getAdmin()->getSubject();
+                if ($parentSubject !== null && $parentSubject !== false) {
+                    // for PropertyAccessor < 2.5
+                    // @todo remove this code for old PropertyAccessor after dropping support for Symfony 2.3
+                    if (!method_exists($p, 'isReadable')) {
+                        $subjectCollection = $p->getValue(
+                            $parentSubject,
+                            $this->getFieldDescription($options)->getFieldName()
+                        );
+                        if ($subjectCollection instanceof Collection) {
+                            $subject = $subjectCollection->get(trim($options['property_path'], '[]'));
+                        }
+                    } else {
+                        // for PropertyAccessor >= 2.5
+                        $subject = $p->getValue(
+                            $parentSubject,
+                            $this->getFieldDescription($options)->getFieldName().$options['property_path']
+                        );
                     }
-                } else {
-                    // for PropertyAccessor >= 2.5
-                    $subject = $p->getValue(
-                        $admin->getParentFieldDescription()->getAdmin()->getSubject(),
-                        $this->getFieldDescription($options)->getFieldName().$options['property_path']
-                    );
+                    $builder->setData($subject);
                 }
-                $builder->setData($subject);
             } catch (NoSuchIndexException $e) {
                 // no object here
             }