-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance Database Reset Commands #54
base: master
Are you sure you want to change the base?
Conversation
Add relative timestamp to unique code expiry Move footer text to description
Less ambiguous variable names Reformat for readability Improve db interaction efficiency Minor wording change/fix
Standardize general flow across each script Provide more information during deletion (estimated time until completion) More efficient flow between free/premium Format for better readability Reduce db interactions where possible
Use $count variable instead of dbCount call to determine whether or not to loop Above change allows moving this call to delete more entries per CC execution, changed ETA calculation to reflect this Avoid extra dbDelMultiple calls, previously relied on 0 entries being deleted to stop
e802a00
to
a00dd9c
Compare
I've made a few more changes here, mainly prompted by 9890313. These changes make the deletetion significantly more efficient, avoiding the extra costly Additionally, I've changed the sdict key casing within the database entry and execdata to be more readable and follow convention. Unrelated to this PR, you may consider changing the CC to |
I saw this but my fluffbutt hasn't come to this yet. Sorry :/ |
This PR adds a number of small changes and features to the dbreset scripts.
Overview of all changes:
randInt
andprintf
instead ofshuffle
)In my testing, this seems to not have any of the known bugs, those being issue #36 and the very recent reports of invalid key errors.