lib/scatterlist: fix memory leak with scsi-mq

Fix a memory leak with scsi-mq triggered by commands with large data transfer length. Fixes: c53c6d6 ("scatterlist: allow chaining to preallocated chunks") Cc: <[email protected]> # 3.17.x Signed-off-by: Tony Battersby <[email protected]> Reviewed-by: Martin K. Petersen <[email protected]> Signed-off-by: Jens Axboe <[email protected]>
Blub · Oct 28, 2014 · c21e59d · c21e59d
1 parent d32f6b5
commit c21e59d
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/lib/scatterlist.c b/lib/scatterlist.c
@@ -203,10 +203,10 @@ void __sg_free_table(struct sg_table *table, unsigned int max_ents,
 		}
 
 		table->orig_nents -= sg_size;
-		if (!skip_first_chunk) {
-			free_fn(sgl, alloc_size);
+		if (skip_first_chunk)
 			skip_first_chunk = false;
-		}
+		else
+			free_fn(sgl, alloc_size);
 		sgl = next;
 	}