Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly pin neuron version when mixing gcc and intel compilers #1791

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

pramodk
Copy link

@pramodk pramodk commented Dec 14, 2022

    depends_on("coreneuron+legacy-unit~caliper", when="@:8.99+coreneuron+legacy-unit~caliper")
    ...
  • Because of this change, spack is now preferring develop version of neuron when we mix gcc and intel:
$ spack spec -I py-bluepyopt%gcc ^neuron%intel
Input spec
--------------------------------
 -   py-bluepyopt%gcc
 -       ^neuron%intel

Concretized
--------------------------------
 -   [email protected]%[email protected]+neuron patches=dc37639246b3a3320c840f1c4f635940b8510a896a667d4707c3d355d9c6fb81 arch=linux-rhel7-skylake
 -       ^neuron@develop%[email protected]+binary~caliper~codegenopt+coreneuron~debug~gpu~interviews~ipo+legacy-fr+legacy-unit+memacs+mod-compatibility+mpi~nmodl~openmp+python+report+rx3d+shared~sympy~sympyopt~tests~unified build_type=RelWithDebInfo model_tests=None patches=708cb04826b394a858069d93e8c08e1e81e914c23e1ef3da0486e8233834ff6c sanitizers=None arch=linux-rhel7-skylake

but with single compiler, it uses last release correctly

$ spack spec -I py-bluepyopt ^neuron%intel
Input spec
--------------------------------
 -   py-bluepyopt
 -       ^neuron%intel

Concretized
--------------------------------
 -   [email protected]%[email protected]+neuron patches=dc37639246b3a3320c840f1c4f635940b8510a896a667d4707c3d355d9c6fb81 arch=linux-rhel7-skylake
 -       ^[email protected]%[email protected]+binary~caliper~codegenopt+coreneuron~debug~gpu~interviews~ipo+legacy-fr+legacy-unit+memacs+mod-compatibility+mpi~nmodl~openmp+python+report+rx3d+shared~sympy~sympyopt~tests~unified build_type=RelWithDebInfo model_tests=None patches=708cb04826b394a858069d93e8c08e1e81e914c23e1ef3da0486e8233834ff6c sanitizers=None arch=linux-rhel7-skylake
 -           ^[email protected]%[email protected] arch=linux-rhel7-skylake
  • I tried various spec changes in neuron and coreneuron by simplifying recipes but don't see any satisfactory change to force spack to use last release than develop. It seems like using upstream versions for common package like ninja also changes spack preference. (related to python dependency)
  • So as part of this PR, pin the last release whenever we are mixing compilers. ANYWAY, this will be removed with Deploy upcoming 9.0a release #1781.
  • NOTE: this PR is just to see all packages will be built without neuron@develop. I will introduce change in neuron recipe to test the same.

* In #1777 we have made coreneuron optional for upcoming neuron > 8
  releases:
```
    depends_on("coreneuron+legacy-unit~caliper", when="@:8.99+coreneuron+legacy-unit~caliper")
    ...
```
* Because of this change, spack is now preferring develop version of
  neuron when we mix gcc with intel:

```
$ spack spec -I py-bluepyopt%gcc ^neuron%intel
Input spec
--------------------------------
 -   py-bluepyopt%gcc
 -       ^neuron%intel

Concretized
--------------------------------
 -   [email protected]%[email protected]+neuron patches=dc37639246b3a3320c840f1c4f635940b8510a896a667d4707c3d355d9c6fb81 arch=linux-rhel7-skylake
 -       ^neuron@develop%[email protected]+binary~caliper~codegenopt+coreneuron~debug~gpu~interviews~ipo+legacy-fr+legacy-unit+memacs+mod-compatibility+mpi~nmodl~openmp+python+report+rx3d+shared~sympy~sympyopt~tests~unified build_type=RelWithDebInfo model_tests=None patches=708cb04826b394a858069d93e8c08e1e81e914c23e1ef3da0486e8233834ff6c sanitizers=None arch=linux-rhel7-skylake
```
  but with single compiler, it uses last release correctly

```
$ spack spec -I py-bluepyopt ^neuron%intel
Input spec
--------------------------------
 -   py-bluepyopt
 -       ^neuron%intel

Concretized
--------------------------------
 -   [email protected]%[email protected]+neuron patches=dc37639246b3a3320c840f1c4f635940b8510a896a667d4707c3d355d9c6fb81 arch=linux-rhel7-skylake
 -       ^[email protected]%[email protected]+binary~caliper~codegenopt+coreneuron~debug~gpu~interviews~ipo+legacy-fr+legacy-unit+memacs+mod-compatibility+mpi~nmodl~openmp+python+report+rx3d+shared~sympy~sympyopt~tests~unified build_type=RelWithDebInfo model_tests=None patches=708cb04826b394a858069d93e8c08e1e81e914c23e1ef3da0486e8233834ff6c sanitizers=None arch=linux-rhel7-skylake
 -           ^[email protected]%[email protected] arch=linux-rhel7-skylake
```
* I tried various spec changes in neuron and coreneuron but don't see
  any satisfactory change to force spack to use last release than
  develop. So as part of this commit, pin the last release whenever
  we are mixing compilers. ANYWAY, this will be removed with #1781.
@bbpbuildbot
Copy link
Collaborator

Thank you for your pull request!

Should you want to clear the PR build directory after failures, please use this pipeline. Before running the cleanup pipeline, please ensure that any PR building pipelines have been cancelled or finished running.

@bbpbuildbot
Copy link
Collaborator

To test your PR, use the following on BlueBrain5:

unset MODULEPATH
. /gpfs/bbp.cscs.ch/ssd/apps/bsd/pulls/1791/config/modules.sh
module load unstable

Please test the following updated modules:

  • py-bluepymm/0.7.65
  • py-bluepyopt/1.10.38
  • py-morph-tool/2.9.0

@pramodk
Copy link
Author

pramodk commented Dec 14, 2022

I tried various spec changes in neuron and coreneuron by simplifying recipes but don't see any satisfactory change to force spack to use last release than develop. It seems like using upstream versions for common package like ninja also changes spack preference. (related to python dependency)

As an example of this, a simplified coreneuron recipe without any dependency (commented out all) gives:

kumbhar@bbpv1:~$ spack spec -I py-bluepyopt%gcc ^neuron%intel
Input spec
--------------------------------
 -   py-bluepyopt%gcc
 -       ^neuron%intel

Concretized
--------------------------------
 -   [email protected]%[email protected]+neuron patches=dc37639246b3a3320c840f1c4f635940b8510a896a667d4707c3d355d9c6fb81 arch=linux-rhel7-skylake
 -       ^[email protected]%[email protected]+binary~caliper~codegenopt+coreneuron~debug~gpu~interviews~ipo+legacy-fr+legacy-unit+memacs+mod-compatibility+mpi~nmodl~openmp+python+report+rx3d+shared~sympy~sympyopt~tests~unified build_type=RelWithDebInfo model_tests=None patches=708cb04826b394a858069d93e8c08e1e81e914c23e1ef3da0486e8233834ff6c sanitizers=None arch=linux-rhel7-skylake
 -           ^[email protected]%[email protected] arch=linux-rhel7-skylake

and then I added back just ninja and python dependencies in coreneuron:

kumbhar@bbpv1:~$ spack spec -I py-bluepyopt%gcc ^neuron%intel
Input spec
--------------------------------
 -   py-bluepyopt%gcc
 -       ^neuron%intel

Concretized
--------------------------------
 -   [email protected]%[email protected]+neuron patches=dc37639246b3a3320c840f1c4f635940b8510a896a667d4707c3d355d9c6fb81 arch=linux-rhel7-skylake
 -       ^neuron@develop%[email protected]+binary~caliper~codegenopt+coreneuron~debug~gpu~interviews~ipo+legacy-fr+legacy-unit+memacs+mod-compatibility+mpi~nmodl~openmp+python+report+rx3d+shared~sympy~sympyopt~tests~unified build_type=RelWithDebInfo model_tests=None patches=708cb04826b394a858069d93e8c08e1e81e914c23e1ef3da0486e8233834ff6c sanitizers=None arch=linux-rhel7-skylake

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants