Transition Region Editor to Tcl/Tk #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Breakthrough
changed the title
Breakthrough
force-pushed
the
issue-181-tk-canvas
branch
9 times, most recently
from
65b28c8 to
b353fb7
Compare
Breakthrough
force-pushed
the
issue-181-tk-canvas
branch
9 times, most recently
from
ee0dc36 to
2ca27c5
Compare
Breakthrough
changed the title
Breakthrough
force-pushed
the
issue-181-tk-canvas
branch
6 times, most recently
from
3990e24 to
053653a
Compare
Breakthrough
force-pushed
the
issue-181-tk-canvas
branch
from
053653a to
7522abd
Compare
This allows for better control over window events and makes input handling more consistent across platforms. It also allows better customization, for example, the system undo/redo commands are used instead of key binds. There is still much work to do, however this is a good starting point, and has feature parity with the existing editor.
Breakthrough
force-pushed
the
issue-181-tk-canvas
branch
from
7522abd to
0ada219
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completely changes how the region editor works and operates much more consistently across platforms. Now it has a proper UI, although keyboard is still required for certain tasks. These will be addressed in a follow-up. #181
The benefits are numerous:
This also paves the way to transition the region editor into the base of a full DVR-Scan GUI app.