Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Windows build instructions to README #50

Merged
merged 2 commits into from
Jul 17, 2022

Conversation

genevanmeter
Copy link

Tested with Windows 10 and ROS 2 Humble binary install.

@BrettRD
Copy link
Owner

BrettRD commented Jul 15, 2022

Thanks so much for writing this!
This would have taken me weeks

I'm getting a linker error looking for a couple of GLib symbols on Windows 10
g_type_*, g_value_*, g_object_* and g_param_*

I have the latest release and devel complete installs of gstreamer, they appear in Path correctly, and basic gst-launch pipelines work from the command line

Do I need to declare another cmake link dependency for GLib? or am I missing a package on my windows box?

(Edit: also, do you happen to know of any ROS2 or GStreamer projects with a Windows CI target I could copy automatic build and test from?)

@genevanmeter
Copy link
Author

genevanmeter commented Jul 15, 2022

I was able to recreate the issue. I have vcpkg integrated to my system for other projects which had already built glib.
Sorry about that. Although to my defense CMakeCache.txt doesn't contain any references to vcpkg or its associated paths and normally I have to explicitly tell it to use the vcpkg toolchain.

With vcpkg (https://vcpkg.io/en/getting-started.html)
vcpkg.exe install glib:x64-windows

Possible issue: vcpkg glib is v2.70.5 vs the gstreamer installers glib v2.62.6.

I will look into making it work without vcpkg. Gstreamer devel installer should have all the necessary components.
Added ${GLIB_GOBJECT_LIBRARIES} to target_link_libraries which should resolve the issue.

As for Windows CI targets, I haven't used them.

@BrettRD BrettRD merged commit 8bdb170 into BrettRD:ros2 Jul 17, 2022
@BrettRD
Copy link
Owner

BrettRD commented Jul 17, 2022

Well spotted with that linker call, this builds on my windows 10 box, and cleans up a loose dependency on Linux targets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants