Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libsoup dependency #65

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Add libsoup dependency #65

merged 1 commit into from
Mar 19, 2024

Conversation

fbe555
Copy link

@fbe555 fbe555 commented Mar 18, 2024

Added libsoup as a build dependency.

Note that this requires the following addition to the ros index to come through first:
ros/rosdistro#40241

@fbe555 fbe555 mentioned this pull request Mar 18, 2024
@BrettRD BrettRD merged commit 1fec78e into BrettRD:develop Mar 19, 2024
@BrettRD
Copy link
Owner

BrettRD commented Mar 19, 2024

Amazing!
I think a similar index change might be required for jsonGLib

@fbe555
Copy link
Author

fbe555 commented Mar 19, 2024

Hi Brett.

I was in a bit of a hurry and only verified that the added dependency installed as intended 😅
It looks like both json-glib-1.0 and gstreamer-webrtc-1.0 needs to be installed. The first one can be installed throught the rosdep key libjson-glib, but the second one I think needs to be installed through the apt package libgstreamer-plugins-bad1.0-dev. I have tested that adding aforementioned dependency and manually installing the apt package leads to a successfull build on a freshly built container. I find the gstreamer plugin partitioning a bit confusing, but if you can confirm that the 'bad' set is needed, I'll add another entry to ros index and make another PR here with the two new dependencies.

Felix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants