Skip to content

Commit

Permalink
Letting Chrome decide "plan-b" or "unified-plan".
Browse files Browse the repository at this point in the history
Previously RTCMultiConnection was forcing "unified-plan" on Chrome which produced errors.

You can force any plan using:
connection.sdpSemantics = 'plan-b';
or:
connection.sdpSemantics = 'unified-plan';
  • Loading branch information
muaz-khan committed Feb 16, 2019
1 parent bb043c0 commit 54d0ae0
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion dev/RTCPeerConnection.js
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ function PeerInitiator(config) {
params.rtcpMuxPolicy = connection.rtcpMuxPolicy;
}

if (DetectRTC.browser.name === 'Chrome') {
if (!!connection.sdpSemantics) {
params.sdpSemantics = connection.sdpSemantics || 'unified-plan';
}

Expand Down
4 changes: 2 additions & 2 deletions dist/RTCMultiConnection.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use strict';

// Last time updated: 2019-02-15 11:27:13 AM UTC
// Last time updated: 2019-02-16 7:11:13 PM UTC

// _________________________
// RTCMultiConnection v3.6.8
Expand Down Expand Up @@ -2547,7 +2547,7 @@ var RTCMultiConnection = function(roomid, forceOptions) {
params.rtcpMuxPolicy = connection.rtcpMuxPolicy;
}

if (DetectRTC.browser.name === 'Chrome') {
if (!!connection.sdpSemantics) {
params.sdpSemantics = connection.sdpSemantics || 'unified-plan';
}

Expand Down
Loading

0 comments on commit 54d0ae0

Please sign in to comment.