Large rewrite #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Features added: - "pet" command menu to manage your pet (https://i.imgur.com/dArkG7l.png) - Transferring pets to other players - Optional Job Lock - Changes - Converted to VORP notifications - Language lines - Updated config options - LUA Optimizations and linting - Future plans - Multiple pets to own - Call multiple pets
|
My apologies on the delayed response, with the size of this update, and just getting back from 2 weeks being gone, just wasn't able to find some solid time. But I will be testing your changes this weekend. Again Thanks a bunch for your continued contributions! |
|
I actually have more to add, multiple pet ownership, conversion to Menu API, transferring pets. I will push an update. |
New features: - Multiple Pets per player - Have multiple Pets out at once and each manageable - Tradeable pets between players - Converted to MenuAPI - Many new Config options
|
@AndrewR3K this contains the full rewrite to test. Updated the initial comment as well to reflect the changes in the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Being a larger rewrite I would request Maintainers test as well.
Features added:
Features removed:
Changes
LUA Optimizations and linting