Skip to content

Commit

Permalink
Tests were failing due to problems with Talkback
Browse files Browse the repository at this point in the history
talkback/index.js: RecordMode.DISABLED uses the tapes if they exist, RecordMode.OVERWRITE will ignore tapes completely.
test_refresh_product: Random number generator breaks the tapes if the test is ran more than once.
  • Loading branch information
alchemistake committed Oct 24, 2019
1 parent aa5fdf7 commit 2e7818c
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions tests/integration/talkback/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ const opts = {
tapeNameGenerator: nameGenerator,

// TEST MODE - uncomment the 2 lines below for testing without using tapes
//record: talkback.Options.RecordMode.DISABLED,
//fallbackMode: talkback.Options.FallbackMode.PROXY
// record: talkback.Options.RecordMode.OVERWRITE,
// fallbackMode: talkback.Options.FallbackMode.PROXY
};
const server = talkback(opts);
server.start();
Expand Down
2 changes: 1 addition & 1 deletion tests/integration/test_product.py
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ def test_refresh_product(builton):
currency="NOK", price=13.90)
assert isinstance(product, Product)

new_price = round(random.uniform(100.0, 200.42), 2)
new_price = 28.10
product.update(price=new_price)
assert new_price != product.price

Expand Down

0 comments on commit 2e7818c

Please sign in to comment.