Deprecate the document argument in Printing.sharePdf()

Bulaimu · May 17, 2019 · 1bda9db · 1bda9db
1 parent 5115814
commit 1bda9db
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 4 deletions.
diff --git a/pdf/CHANGELOG.md b/pdf/CHANGELOG.md
@@ -1,3 +1,6 @@
+# 1.3.10
+* Deprecate the document argument in Printing.sharePdf()
+
 # 1.3.9
 * Fix Transform Widget alignment
 * Fix CustomPaint Widget size

diff --git a/pdf/pubspec.yaml b/pdf/pubspec.yaml
@@ -4,7 +4,7 @@ description: A pdf producer for Dart. It can create pdf files for both web or fl
 homepage: https://github.com/DavBfr/dart_pdf/tree/master/pdf
 repository: https://github.com/DavBfr/dart_pdf
 issue_tracker: https://github.com/DavBfr/dart_pdf/issues
-version: 1.3.9
+version: 1.3.10
 
 environment:
   sdk: ">=2.1.0 <3.0.0"

diff --git a/printing/CHANGELOG.md b/printing/CHANGELOG.md
@@ -1,6 +1,7 @@
 # 2.0.3
 * Add file save and view to example application
 * Convert print screen example to Widgets
+* Deprecate the document argument in Printing.sharePdf()
 
 # 2.0.2
 * Fix example application

diff --git a/printing/lib/src/printing.dart b/printing/lib/src/printing.dart
@@ -52,8 +52,10 @@ mixin Printing {
   }
 
   /// Prints a [PdfDocument] or a pdf stream to a local printer using the platform UI
-  @deprecated
-  static Future<void> printPdf({PdfDocument document, List<int> bytes}) async {
+  @Deprecated('use Printing.layoutPdf(onLayout: (_) => document.save());')
+  static Future<void> printPdf(
+      {@Deprecated('use bytes with document.save()') PdfDocument document,
+      List<int> bytes}) async {
     assert(document != null || bytes != null);
     assert(!(document == null && bytes == null));
 
@@ -64,7 +66,7 @@ mixin Printing {
 
   /// Displays a platform popup to share the Pdf document to another application
   static Future<void> sharePdf(
-      {PdfDocument document,
+      {@Deprecated('use bytes with document.save()') PdfDocument document,
       List<int> bytes,
       String filename,
       Rect bounds}) async {