Skip to content

Commit

Permalink
[GR-28769] Adapt to mx changes in benchSuiteVersion.
Browse files Browse the repository at this point in the history
PullRequest: graal/9116
  • Loading branch information
farquet committed Jun 11, 2021
2 parents 41cb943 + 83eb488 commit dbe78ab
Show file tree
Hide file tree
Showing 11 changed files with 19 additions and 20 deletions.
6 changes: 3 additions & 3 deletions compiler/mx.compiler/mx_graal_benchmark.py
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ def vmArgs(self, bmSuiteArgs):
def getBenchmarkName(self):
raise NotImplementedError()

def benchSuiteName(self):
def benchSuiteName(self, bmSuiteArgs=None):
raise NotImplementedError()

def shorten_vm_flags(self, args):
Expand Down Expand Up @@ -395,7 +395,7 @@ def run(self, benchmarks, bmSuiteArgs):
class DaCapoTimingBenchmarkSuite(DaCapoTimingBenchmarkMixin, DaCapoBenchmarkSuite): # pylint: disable=too-many-ancestors
"""DaCapo 9.12 (Bach) benchmark suite implementation."""

def benchSuiteName(self):
def benchSuiteName(self, bmSuiteArgs=None):
return "dacapo"


Expand All @@ -405,7 +405,7 @@ def benchSuiteName(self):
class ScalaDaCapoTimingBenchmarkSuite(DaCapoTimingBenchmarkMixin, ScalaDaCapoBenchmarkSuite): # pylint: disable=too-many-ancestors
"""Scala DaCapo benchmark suite implementation."""

def benchSuiteName(self):
def benchSuiteName(self, bmSuiteArgs=None):
return "scala-dacapo"


Expand Down
2 changes: 1 addition & 1 deletion compiler/mx.compiler/suite.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
suite = {
"mxversion" : "5.292.5",
"mxversion" : "5.301.0",
"name" : "compiler",
"sourceinprojectwhitelist" : [],

Expand Down
3 changes: 0 additions & 3 deletions java-benchmarks/mx.java-benchmarks/mx_java_benchmarks.py
Original file line number Diff line number Diff line change
Expand Up @@ -547,9 +547,6 @@ def group(self):
def subgroup(self):
return "graal-compiler"

def benchSuiteName(self):
return self.name()

def daCapoClasspathEnvVarName(self):
raise NotImplementedError()

Expand Down
2 changes: 1 addition & 1 deletion java-benchmarks/mx.java-benchmarks/suite.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
suite = {
"mxversion" : "5.287.0",
"mxversion" : "5.301.0",
"name": "java-benchmarks",

"javac.lint.overrides": "none",
Expand Down
3 changes: 0 additions & 3 deletions sdk/mx.sdk/mx_sdk_benchmark.py
Original file line number Diff line number Diff line change
Expand Up @@ -202,9 +202,6 @@ def __init__(self):
self.parser.add_argument("--workload-configuration", type=str, default=None, help="Path to workload configuration.")
self.parser.add_argument("--skip-latency-measurements", action='store_true', default=False, help="Determines if the latency measurements should be skipped.")

def benchSuiteName(self):
return self.name()

def benchMicroserviceName(self):
"""
Returns the microservice name. The convention here is that the benchmark name contains two elements separated
Expand Down
2 changes: 1 addition & 1 deletion sdk/mx.sdk/suite.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
# SOFTWARE.
#
suite = {
"mxversion" : "5.297.0",
"mxversion" : "5.301.0",
"name" : "sdk",
"version" : "21.2.0",
"release" : False,
Expand Down
6 changes: 3 additions & 3 deletions substratevm/mx.substratevm/mx_substratevm_benchmark.py
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ class RenaissanceNativeImageBenchmarkSuite(mx_java_benchmarks.RenaissanceBenchma
def name(self):
return 'renaissance-native-image'

def benchSuiteName(self):
def benchSuiteName(self, bmSuiteArgs=None):
return 'renaissance'

def renaissance_harness_lib_name(self):
Expand Down Expand Up @@ -438,7 +438,7 @@ def daCapoPath(self):
def daCapoSuiteTitle(self):
return super(DaCapoNativeImageBenchmarkSuite, self).suite_title()

def benchSuiteName(self):
def benchSuiteName(self, bmSuiteArgs=None):
return 'dacapo'

def daCapoIterations(self):
Expand Down Expand Up @@ -571,7 +571,7 @@ def daCapoPath(self):
return lib.get_path(True)
return None

def benchSuiteName(self):
def benchSuiteName(self, bmSuiteArgs=None):
return 'scala-dacapo'

def daCapoIterations(self):
Expand Down
2 changes: 1 addition & 1 deletion substratevm/mx.substratevm/suite.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
suite = {
"mxversion": "5.294.0",
"mxversion": "5.301.0",
"name": "substratevm",
"version" : "21.2.0",
"release" : False,
Expand Down
2 changes: 1 addition & 1 deletion vm/mx.vm/suite.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
suite = {
"name": "vm",
"version" : "21.2.0",
"mxversion" : "5.299.0",
"mxversion" : "5.301.0",
"release" : False,
"groupId" : "org.graalvm",

Expand Down
9 changes: 7 additions & 2 deletions wasm/mx.wasm/mx_wasm_benchmark.py
Original file line number Diff line number Diff line change
Expand Up @@ -212,8 +212,13 @@ def name(self):
def group(self):
return "Graal"

def benchSuiteName(self, bmSuiteArgs):
return next(arg for arg in bmSuiteArgs if arg.endswith("BenchmarkSuite"))
def benchSuiteName(self, bmSuiteArgs=None):
if bmSuiteArgs is None:
bmSuiteArgs = []
try:
return next(arg for arg in bmSuiteArgs if arg.endswith("BenchmarkSuite"))
except StopIteration:
return self.name()

def subgroup(self):
return "wasm"
Expand Down
2 changes: 1 addition & 1 deletion wasm/mx.wasm/suite.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
# SOFTWARE.
#
suite = {
"mxversion" : "5.249.5",
"mxversion" : "5.301.0",
"name" : "wasm",
"groupId" : "org.graalvm.wasm",
"version" : "21.2.0",
Expand Down

0 comments on commit dbe78ab

Please sign in to comment.