Skip to content

Commit

Permalink
asmstreamerize the .size directive for function bodies, force clients
Browse files Browse the repository at this point in the history
of printOffset to pass in a stream to print to.


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@100296 91177308-0d34-0410-b5e6-96231b3b80d8
  • Loading branch information
lattner committed Apr 3, 2010
1 parent fd60b8b commit 0c08d09
Show file tree
Hide file tree
Showing 7 changed files with 22 additions and 24 deletions.
7 changes: 1 addition & 6 deletions include/llvm/CodeGen/AsmPrinter.h
Original file line number Diff line number Diff line change
Expand Up @@ -269,11 +269,6 @@ namespace llvm {
///
void EmitInt32(int Value) const;

/// EmitInt64 - Emit a long long directive and value.
///
void EmitInt64(uint64_t Value) const;


/// EmitLabelDifference - Emit something like ".long Hi-Lo" where the size
/// in bytes of the directive is specified by Size and Hi/Lo specify the
/// labels. This implicitly uses .set if it is available.
Expand Down Expand Up @@ -349,7 +344,7 @@ namespace llvm {
virtual void EmitMachineConstantPoolValue(MachineConstantPoolValue *MCPV);

/// printOffset - This is just convenient handler for printing offsets.
void printOffset(int64_t Offset) const;
void printOffset(int64_t Offset, raw_ostream &OS) const;

/// isBlockOnlyReachableByFallthough - Return true if the basic block has
/// exactly one predecessor and the control transfer mechanism between
Expand Down
23 changes: 13 additions & 10 deletions lib/CodeGen/AsmPrinter/AsmPrinter.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -461,7 +461,16 @@ void AsmPrinter::EmitFunctionBody() {
// If the target wants a .size directive for the size of the function, emit
// it.
if (MAI->hasDotTypeDotSizeDirective()) {
O << "\t.size\t" << *CurrentFnSym << ", .-" << *CurrentFnSym << '\n';
// Create a symbol for the end of function, so we can get the size as
// difference between the function label and the temp label.
MCSymbol *FnEndLabel = OutContext.CreateTempSymbol();
OutStreamer.EmitLabel(FnEndLabel);

const MCExpr *SizeExp =
MCBinaryExpr::CreateSub(MCSymbolRefExpr::Create(FnEndLabel, OutContext),
MCSymbolRefExpr::Create(CurrentFnSym, OutContext),
OutContext);
OutStreamer.EmitELFSize(CurrentFnSym, SizeExp);
}

// Emit post-function debug information.
Expand Down Expand Up @@ -922,12 +931,6 @@ void AsmPrinter::EmitInt32(int Value) const {
OutStreamer.EmitIntValue(Value, 4, 0/*addrspace*/);
}

/// EmitInt64 - Emit a long long directive and value.
///
void AsmPrinter::EmitInt64(uint64_t Value) const {
OutStreamer.EmitIntValue(Value, 8, 0/*addrspace*/);
}

/// EmitLabelDifference - Emit something like ".long Hi-Lo" where the size
/// in bytes of the directive is specified by Size and Hi/Lo specify the
/// labels. This implicitly uses .set if it is available.
Expand Down Expand Up @@ -1822,11 +1825,11 @@ void AsmPrinter::EmitVisibility(MCSymbol *Sym, unsigned Visibility) const {
OutStreamer.EmitSymbolAttribute(Sym, Attr);
}

void AsmPrinter::printOffset(int64_t Offset) const {
void AsmPrinter::printOffset(int64_t Offset, raw_ostream &OS) const {
if (Offset > 0)
O << '+' << Offset;
OS << '+' << Offset;
else if (Offset < 0)
O << Offset;
OS << Offset;
}

/// isBlockOnlyReachableByFallthough - Return true if the basic block has
Expand Down
2 changes: 1 addition & 1 deletion lib/Target/ARM/AsmPrinter/ARMAsmPrinter.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -319,7 +319,7 @@ void ARMAsmPrinter::printOperand(const MachineInstr *MI, int OpNum,
O << ":upper16:";
O << *Mang->getSymbol(GV);

printOffset(MO.getOffset());
printOffset(MO.getOffset(), O);

if (isCallOp && Subtarget->isTargetELF() &&
TM.getRelocationModel() == Reloc::PIC_)
Expand Down
2 changes: 1 addition & 1 deletion lib/Target/Blackfin/AsmPrinter/BlackfinAsmPrinter.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ void BlackfinAsmPrinter::printOperand(const MachineInstr *MI, int opNum) {
return;
case MachineOperand::MO_GlobalAddress:
O << *Mang->getSymbol(MO.getGlobal());
printOffset(MO.getOffset());
printOffset(MO.getOffset(), O);
break;
case MachineOperand::MO_ExternalSymbol:
O << *GetExternalSymbolSymbol(MO.getSymbolName());
Expand Down
2 changes: 1 addition & 1 deletion lib/Target/PowerPC/AsmPrinter/PPCAsmPrinter.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -446,7 +446,7 @@ void PPCAsmPrinter::printOp(const MachineOperand &MO) {

O << *SymToPrint;

printOffset(MO.getOffset());
printOffset(MO.getOffset(), O);
return;
}

Expand Down
6 changes: 3 additions & 3 deletions lib/Target/SystemZ/AsmPrinter/SystemZAsmPrinter.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ void SystemZAsmPrinter::printPCRelImmOperand(const MachineInstr *MI, int OpNum){
!GV->hasLocalLinkage())
O << "@PLT";

printOffset(MO.getOffset());
printOffset(MO.getOffset(), O);
return;
}
case MachineOperand::MO_ExternalSymbol: {
Expand Down Expand Up @@ -155,7 +155,7 @@ void SystemZAsmPrinter::printOperand(const MachineInstr *MI, int OpNum,
O << MAI->getPrivateGlobalPrefix() << "CPI" << getFunctionNumber() << '_'
<< MO.getIndex();

printOffset(MO.getOffset());
printOffset(MO.getOffset(), O);
break;
case MachineOperand::MO_GlobalAddress:
O << *Mang->getSymbol(MO.getGlobal());
Expand All @@ -177,7 +177,7 @@ void SystemZAsmPrinter::printOperand(const MachineInstr *MI, int OpNum,
case SystemZII::MO_PLT: O << "@PLT"; break;
}

printOffset(MO.getOffset());
printOffset(MO.getOffset(), O);
}

void SystemZAsmPrinter::printRIAddrOperand(const MachineInstr *MI, int OpNum,
Expand Down
4 changes: 2 additions & 2 deletions lib/Target/X86/AsmPrinter/X86AsmPrinter.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ void X86AsmPrinter::printSymbolOperand(const MachineOperand &MO) {
break;
case MachineOperand::MO_ConstantPoolIndex:
O << *GetCPISymbol(MO.getIndex());
printOffset(MO.getOffset());
printOffset(MO.getOffset(), O);
break;
case MachineOperand::MO_GlobalAddress: {
const GlobalValue *GV = MO.getGlobal();
Expand Down Expand Up @@ -136,7 +136,7 @@ void X86AsmPrinter::printSymbolOperand(const MachineOperand &MO) {
O << *GVSym;
else
O << '(' << *GVSym << ')';
printOffset(MO.getOffset());
printOffset(MO.getOffset(), O);
break;
}
case MachineOperand::MO_ExternalSymbol: {
Expand Down

0 comments on commit 0c08d09

Please sign in to comment.