Skip to content

Commit

Permalink
ADT/Triple: Renambe isOSX... methods to isMacOSX for consistency with…
Browse files Browse the repository at this point in the history
… the OS

triple component.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@129838 91177308-0d34-0410-b5e6-96231b3b80d8
  • Loading branch information
ddunbar committed Apr 20, 2011
1 parent 4aaf346 commit 558692f
Show file tree
Hide file tree
Showing 9 changed files with 24 additions and 22 deletions.
12 changes: 6 additions & 6 deletions include/llvm/ADT/Triple.h
Original file line number Diff line number Diff line change
Expand Up @@ -266,15 +266,15 @@ class Triple {
return false;
}

/// isOSX - Is this an OS X triple. For legacy reasons, we support both
/// isMacOSX - Is this a Mac OS X triple. For legacy reasons, we support both
/// "darwin" and "osx" as OS X triples.
bool isOSX() const {
bool isMacOSX() const {
return getOS() == Triple::Darwin || getOS() == Triple::MacOSX;
}

/// isOSDarwin - Is this a "Darwin" OS (OS X or iOS).
bool isOSDarwin() const {
return isOSX() ||getOS() == Triple::IOS;
return isMacOSX() ||getOS() == Triple::IOS;
}

/// isOSWindows - Is this a "Windows" OS.
Expand All @@ -283,12 +283,12 @@ class Triple {
getOS() == Triple::MinGW32;
}

/// isOSXVersionLT - Comparison function for checking OS X version
/// isMacOSXVersionLT - Comparison function for checking OS X version
/// compatibility, which handles supporting skewed version numbering schemes
/// used by the "darwin" triples.
unsigned isOSXVersionLT(unsigned Major, unsigned Minor = 0,
unsigned isMacOSXVersionLT(unsigned Major, unsigned Minor = 0,
unsigned Micro = 0) const {
assert(isOSX() && "Not an OS X triple!");
assert(isMacOSX() && "Not an OS X triple!");

// If this is OS X, expect a sane version number.
if (getOS() == Triple::MacOSX)
Expand Down
2 changes: 1 addition & 1 deletion lib/CodeGen/TargetLoweringObjectFileImpl.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -481,7 +481,7 @@ void TargetLoweringObjectFileMachO::Initialize(MCContext &Ctx,

// .comm doesn't support alignment before Leopard.
Triple T(((LLVMTargetMachine&)TM).getTargetTriple());
if (T.isOSX() && T.isOSXVersionLT(10, 5))
if (T.isMacOSX() && T.isMacOSXVersionLT(10, 5))
CommDirectiveSupportsAlignment = false;

TargetLoweringObjectFile::Initialize(Ctx, TM);
Expand Down
8 changes: 4 additions & 4 deletions lib/Target/PowerPC/PPCISelLowering.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2444,8 +2444,8 @@ unsigned PrepareCall(SelectionDAG &DAG, SDValue &Callee, SDValue &InFlag,
if (!DAG.getTarget().getSubtarget<PPCSubtarget>().isJITCodeModel()) {
unsigned OpFlags = 0;
if (DAG.getTarget().getRelocationModel() != Reloc::Static &&
(!PPCSubTarget.getTargetTriple().isOSX() ||
PPCSubTarget.getTargetTriple().isOSXVersionLT(10, 5)) &&
(!PPCSubTarget.getTargetTriple().isMacOSX() ||
PPCSubTarget.getTargetTriple().isMacOSXVersionLT(10, 5)) &&
(G->getGlobal()->isDeclaration() ||
G->getGlobal()->isWeakForLinker())) {
// PC-relative references to external symbols should go through $stub,
Expand All @@ -2468,8 +2468,8 @@ unsigned PrepareCall(SelectionDAG &DAG, SDValue &Callee, SDValue &InFlag,
unsigned char OpFlags = 0;

if (DAG.getTarget().getRelocationModel() != Reloc::Static &&
(!PPCSubTarget.getTargetTriple().isOSX() ||
PPCSubTarget.getTargetTriple().isOSXVersionLT(10, 5))) {
(!PPCSubTarget.getTargetTriple().isMacOSX() ||
PPCSubTarget.getTargetTriple().isMacOSXVersionLT(10, 5))) {
// PC-relative references to external symbols should go through $stub,
// unless we're building with the leopard linker or later, which
// automatically synthesizes these stubs.
Expand Down
2 changes: 1 addition & 1 deletion lib/Target/PowerPC/PPCSubtarget.h
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ class PPCSubtarget : public TargetSubtarget {
const Triple &getTargetTriple() const { return TargetTriple; }

/// isDarwin - True if this is any darwin platform.
bool isDarwin() const { return TargetTriple.isOSX(); }
bool isDarwin() const { return TargetTriple.isMacOSX(); }

bool isDarwinABI() const { return isDarwin(); }
bool isSVR4ABI() const { return !isDarwin(); }
Expand Down
4 changes: 2 additions & 2 deletions lib/Target/TargetLibraryInfo.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ static void initialize(TargetLibraryInfo &TLI, const Triple &T) {


// memset_pattern16 is only available on iOS 3.0 and Mac OS/X 10.5 and later.
if (T.isOSX()) {
if (T.isOSXVersionLT(10, 5))
if (T.isMacOSX()) {
if (T.isMacOSXVersionLT(10, 5))
TLI.setUnavailable(LibFunc::memset_pattern16);
} else if (T.getOS() == Triple::IOS) {
if (T.isOSVersionLT(3, 0))
Expand Down
4 changes: 2 additions & 2 deletions lib/Target/X86/X86FastISel.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1773,8 +1773,8 @@ bool X86FastISel::X86SelectCall(const Instruction *I) {
OpFlags = X86II::MO_PLT;
} else if (Subtarget->isPICStyleStubAny() &&
(GV->isDeclaration() || GV->isWeakForLinker()) &&
(!Subtarget->getTargetTriple().isOSX() ||
Subtarget->getTargetTriple().isOSXVersionLT(10, 5))) {
(!Subtarget->getTargetTriple().isMacOSX() ||
Subtarget->getTargetTriple().isMacOSXVersionLT(10, 5))) {
// PC-relative references to external symbols should go through $stub,
// unless we're building with the leopard linker or later, which
// automatically synthesizes these stubs.
Expand Down
8 changes: 4 additions & 4 deletions lib/Target/X86/X86ISelLowering.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2281,8 +2281,8 @@ X86TargetLowering::LowerCall(SDValue Chain, SDValue Callee,
OpFlags = X86II::MO_PLT;
} else if (Subtarget->isPICStyleStubAny() &&
(GV->isDeclaration() || GV->isWeakForLinker()) &&
(!Subtarget->getTargetTriple().isOSX() ||
Subtarget->getTargetTriple().isOSXVersionLT(10, 5))) {
(!Subtarget->getTargetTriple().isMacOSX() ||
Subtarget->getTargetTriple().isMacOSXVersionLT(10, 5))) {
// PC-relative references to external symbols should go through $stub,
// unless we're building with the leopard linker or later, which
// automatically synthesizes these stubs.
Expand All @@ -2301,8 +2301,8 @@ X86TargetLowering::LowerCall(SDValue Chain, SDValue Callee,
getTargetMachine().getRelocationModel() == Reloc::PIC_) {
OpFlags = X86II::MO_PLT;
} else if (Subtarget->isPICStyleStubAny() &&
(!Subtarget->getTargetTriple().isOSX() ||
Subtarget->getTargetTriple().isOSXVersionLT(10, 5))) {
(!Subtarget->getTargetTriple().isMacOSX() ||
Subtarget->getTargetTriple().isMacOSXVersionLT(10, 5))) {
// PC-relative references to external symbols should go through $stub,
// unless we're building with the leopard linker or later, which
// automatically synthesizes these stubs.
Expand Down
3 changes: 2 additions & 1 deletion lib/Target/X86/X86Subtarget.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,8 @@ ClassifyGlobalReference(const GlobalValue *GV, const TargetMachine &TM) const {
/// passed as the second argument. Otherwise it returns null.
const char *X86Subtarget::getBZeroEntry() const {
// Darwin 10 has a __bzero entry point for this purpose.
if (getTargetTriple().isOSX() && !getTargetTriple().isOSXVersionLT(10, 6))
if (getTargetTriple().isMacOSX() &&
!getTargetTriple().isMacOSXVersionLT(10, 6))
return "__bzero";

return 0;
Expand Down
3 changes: 2 additions & 1 deletion tools/llc/llc.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,8 @@ int main(int argc, char **argv) {
Target.setMCUseLoc(false);

// Disable .loc support for older OS X versions.
if (TheTriple.isOSX() && TheTriple.isOSXVersionLT(10, 5))
if (TheTriple.isMacOSX() &&
TheTriple.isMacOSXVersionLT(10, 5))
Target.setMCUseLoc(false);

// Figure out where we are going to send the output...
Expand Down

0 comments on commit 558692f

Please sign in to comment.