Skip to content

Commit

Permalink
[LIT] Move display of unsupported and xfail tests to summary.
Browse files Browse the repository at this point in the history
Summary:
This patch changes the way xfail and unsupported tests are displayed. 
This output is only displayed when the --show-unsupported/--show-xfail flags are passed to lit.

Currently xfail/unsupported tests are printed during the run of the test-suite. I think its better to display this information during the summary instead.
This patch removes the printing of these tests from when they are run to the summary.


Reviewers: ddunbar, EricWF

Reviewed By: EricWF

Subscribers: llvm-commits

Differential Revision: http://reviews.llvm.org/D4842

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@215809 91177308-0d34-0410-b5e6-96231b3b80d8
  • Loading branch information
EricWF committed Aug 16, 2014
1 parent 1d8c9d9 commit e1167f1
Showing 1 changed file with 7 additions and 4 deletions.
11 changes: 7 additions & 4 deletions utils/lit/lit/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,6 @@ def update(self, test):
test.getFullName())

shouldShow = test.result.code.isFailure or \
(self.opts.show_unsupported and test.result.code.name == 'UNSUPPORTED') or \
(self.opts.show_xfail and test.result.code.name == 'XFAIL') or \
(not self.opts.quiet and not self.opts.succinct)
if not shouldShow:
return
Expand Down Expand Up @@ -391,7 +389,12 @@ def main(builtinParameters = {}):
# Print each test in any of the failing groups.
for title,code in (('Unexpected Passing Tests', lit.Test.XPASS),
('Failing Tests', lit.Test.FAIL),
('Unresolved Tests', lit.Test.UNRESOLVED)):
('Unresolved Tests', lit.Test.UNRESOLVED),
('Unsupported Tests', lit.Test.UNSUPPORTED),
('Expected Failing Tests', lit.Test.XFAIL)):
if (lit.Test.XFAIL == code and not opts.show_xfail) or \
(lit.Test.UNSUPPORTED == code and not opts.show_unsupported):
continue
elts = byCode.get(code)
if not elts:
continue
Expand All @@ -412,7 +415,7 @@ def main(builtinParameters = {}):
('Unsupported Tests ', lit.Test.UNSUPPORTED),
('Unresolved Tests ', lit.Test.UNRESOLVED),
('Unexpected Passes ', lit.Test.XPASS),
('Unexpected Failures', lit.Test.FAIL),):
('Unexpected Failures', lit.Test.FAIL)):
if opts.quiet and not code.isFailure:
continue
N = len(byCode.get(code,[]))
Expand Down

0 comments on commit e1167f1

Please sign in to comment.