Add odd gate folding #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ss2165
requested changes
Oct 11, 2021
|
|
||
| if fold: | ||
| # for _ in range(noise_scaling - 1): | ||
| command_circ_dict = c_dict.copy() |
There was a problem hiding this comment.
small optimisation suggestion
put this outside the loop:
command_circ_dict= {key: val for key, val in c_dict.items() if key != "commands"}
then in the loop
command_circ_dict.update({"commands": [command]})
There was a problem hiding this comment.
Nice, thanks!
|
|
||
| # Append command and inverse the appropriate number of times. | ||
| folded_command_list.append(command) | ||
| for _ in range(cast(int, noise_scaling) - 1): |
There was a problem hiding this comment.
if noise_scaling is assumed to be an int, it should have an int type signature
Co-authored-by: Seyon Sivarajah <[email protected]>
Co-authored-by: Seyon Sivarajah <[email protected]>
Co-authored-by: Seyon Sivarajah <[email protected]>
ss2165
requested changes
Oct 13, 2021
| @@ -190,11 +190,11 @@ def odd_gate(circ: Circuit, noise_scaling: float) -> Circuit: | |||
|
|
|||
| for command in c_dict["commands"]: | |||
|
|
|||
| command_circ_dict= {key: val for key, val in c_dict.items() if key != "commands"} | |||
There was a problem hiding this comment.
this can be put outside the loop, those values don't change between iterations
There was a problem hiding this comment.
ah yeah, cheers!
| folded_command_list.append( | ||
| { | ||
| "args": command["args"], | ||
| "op": { | ||
| "signature": ["Q" for _ in command["args"]], | ||
| "signature": ["Q"]*len(command["args"]), |
There was a problem hiding this comment.
Ah yeah, thanks!
ss2165
approved these changes
Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new gate folding technique. In particular odd gates are folded until the noise is appropriately scaled.