Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Vectorisation - of and vectorised application #47

Merged
merged 31 commits into from
Oct 31, 2024
Merged

feat: Vectorisation - of and vectorised application #47

merged 31 commits into from
Oct 31, 2024

Conversation

croyzor
Copy link
Collaborator

@croyzor croyzor commented Oct 25, 2024 •
edited
Loading

Previously reviewed by Mark on the old repo.
I've addressed most of the comments:

  • Fix the bug in the Chky case of Of
  • Add type errors instead of hard failing in error cases
  • Add more test cases, incorporating the one's Mark highlighted as going wrong into vectorise.brat

@croyzor croyzor requested a review from mark-koch October 25, 2024 17:01
@croyzor croyzor marked this pull request as draft October 28, 2024 09:32
mark-koch
mark-koch approved these changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@mark-koch mark-koch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, the new tests and comments are great! The checking case makes sense to me now 👍

brat/Brat/Checker.hs Show resolved Hide resolved
brat/Brat/Checker.hs Outdated Show resolved Hide resolved
brat/Brat/Checker.hs Outdated Show resolved Hide resolved
@croyzor croyzor marked this pull request as ready for review October 30, 2024 14:47
@croyzor croyzor requested a review from mark-koch October 30, 2024 14:48
@croyzor croyzor merged commit c8039aa into main Oct 31, 2024
1 check passed
@croyzor croyzor deleted the new/vectorise branch October 31, 2024 15:20
@croyzor croyzor mentioned this pull request Nov 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mark-koch mark-koch mark-koch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@croyzor @mark-koch