feat: Special cased array, float and int constants in hugr-model export #1857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1857 +/- ##
==========================================
- Coverage 86.52% 86.52% -0.01%
==========================================
Files 194 194
Lines 35250 35352 +102
Branches 32063 32165 +102
==========================================
+ Hits 30501 30588 +87
- Misses 2973 2975 +2
- Partials 1776 1789 +13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
This PR contains breaking changes to the public Rust API. cargo-semver-checks summary |
zrho
force-pushed
the
zrho/model-compact-arrays
branch
from
7b7bc0d to
b588731
Compare
ss2165
reviewed
Jan 17, 2025
| (@ arithmetic.float.types.float64)]])] | ||
| (ext)))))) | ||
|
|
||
| (define-func example.f64 | ||
| (define-func example.f64-json |
| @@ -27,12 +27,13 @@ declarative = ["hugr-core/declarative"] | |||
| model_unstable = ["hugr-core/model_unstable", "hugr-model"] | |||
| llvm = ["hugr-llvm/llvm14-0"] | |||
| llvm-test = ["hugr-llvm/llvm14-0", "hugr-llvm/test-utils"] | |||
| default = ["model_unstable"] | |||
There was a problem hiding this comment.
Uhm. I think we should do unstable XOR default
| self.print_text(format!("{:?}", value.into_inner())); | ||
| Ok(()) | ||
| } | ||
| Term::FloatType => { |
There was a problem hiding this comment.
looks like float type isn't being covered, pls add to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR special cases the import/export of array, float and int constants so that they are represented as terms in
hugr-model. This representation is a lot more efficient to handle than the encoding as JSON. In the future we should do this for all constants.