Add DisCoCirc extension to lambeq #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Colin Krawchuk <[email protected]>
|
Let's do the following before we merge this:
|
dimkart
reviewed
Nov 11, 2024
|
|
||
| ## Installation | ||
|
|
||
| Installing the experimental subpackage requires Python 3.10. |
There was a problem hiding this comment.
"Python 3.10 or higher", right?
dimkart
reviewed
Nov 11, 2024
| reader.text2circuit('Alice likes Bob. Bob likes Alice too.').draw() | ||
| ``` | ||
|
|
||
| To get DisCoCirc diagrams with frames decomposed into multiple boxes: |
There was a problem hiding this comment.
Need to add a reference here in one of the DisCoCirc papers that mentions Sandwich functor.
dimkart
reviewed
Nov 11, 2024
| @@ -0,0 +1,30 @@ | |||
| # DisCoCirc extension for lambeq | |||
|
|
|||
| Functionality to convert text into DisCoCirc string diagrams, using lambeq's grammar backend. | |||
There was a problem hiding this comment.
Reference to original paper.
dimkart
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the DisCoCirc reader as an addon to lambeq.
The new functionality is included in the
lambeq.experimental.discocircsubpackage.New features include:
DisCoCircReader, which provides atext2circuitmethod to parse text into disco-circuits.CoreferenceResolverabstract class which returns tokenised text, and associated coref information.SpacyCoreferenceResolverimplementation of the above.TreeRewriteRules, which implementic semantic modification of trees made ofPregroupTreeNode.The
DisCoCircReaderworks by getting thePregroupTreeNodetree for each sentence in a given text, and recursively converting it into a circuital diagram, in a single postorder traversal over the tree.