fix: use {} instead of nil

Otherwise get an exception while creating a new database. Test must be matched to this.
CSCfi · Nov 21, 2024 · e702c4b · e702c4b
1 parent a34e4b5
commit e702c4b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/clj/rems/db/applications.clj b/src/clj/rems/db/applications.clj
@@ -201,7 +201,7 @@
            (group-users-by-role apps)))))
 
 (defn- user-roles-frequencies [applications]
-  (when (seq applications)
+  (if (seq applications)
     (let [all-user-roles (->> applications
                               (eduction (map val)
                                         (mapcat :application/user-roles)))
@@ -219,7 +219,8 @@
                   roles-by-user
                   users)
           (dissoc! ::users)
-          persistent!))))
+          persistent!))
+    {}))
 
 (defn- update-user-roles [updated-users old-roles-by-user old-updated-enriched-apps new-updated-enriched-apps]
   (let [all-old-app-roles (user-roles-frequencies old-updated-enriched-apps)

diff --git a/test/clj/rems/application/test_model.clj b/test/clj/rems/application/test_model.clj
@@ -1302,7 +1302,7 @@
                                 :event/actor-attributes {:userid "handler" :email "[email protected]" :name "Handler" :secret "secret"}
                                 :event/visibility :visibility/public}]
           :application/user-roles {"handler" #{:handler}, "reporter1" #{:reporter}}
-          :application/role-permissions nil
+          :application/role-permissions {}
           :application/description "foo"
           :application/forms [{:form/id 40
                                :form/title "form name" ; deprecated