-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HMC sampler #449
base: main
Are you sure you want to change the base?
HMC sampler #449
Conversation
I believe the samplers are working as expected and they are also in CUQIpy format. Nevertheless, some test are failing due to the changes I did in NUTS. I hope someone can take it from here @jakobsj |
Thank you very much @furibec for adding your HMC sampler, the fixes as well as a demo validating the implementation, that is most helpful! I cannot promise when we'll be able to look at this but I hope it will be soon. |
_hmc.py
contained the NUTS implementation, so I renamed it to_nuts.py
neg_Hamiltonian
function and added some explanation, improved epsilon adaptation functions, and a few changes in theBuildTree
while I was checking everything looks correct.