Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove subfix new and move mcmc out of experimental #476

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

chaozg
Copy link
Contributor

@chaozg chaozg commented Aug 17, 2024

related to #40 from CUQI-Book

TLDR:
cuqi.experimental.mcmc.NUTSNew -> cuqi.mcmc.NUTS

In details:

  • removed subfix "New" from names of samplers at experimental.mcmc: moved to Remove postfix New (only) from sampler names #477
  • moved mcmc module out of experimental
  • experimental module is left there for future experimental work though it's empty now
  • updated tests/zexperimental/test_mcmc
  • updated new sampler-related demos: demo36 and demo37

@nabriis suggested:

  • I think we should check the feasibility of using the new samplers in BaysianProblem & the training material before moving it out of experiemental module
  • If we move it out of experimental, I think we need to move the sampler module into somewhere like "legacy"

@chaozg chaozg requested review from amal-ghamdi and nabriis August 17, 2024 12:39
@chaozg chaozg changed the title Remove subfix new from mcmc samplers Remove subfix new and move mcmc out of experimental Aug 17, 2024
@chaozg chaozg marked this pull request as draft August 17, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant