Multiple Inputs: update the Model module #610
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amal-ghamdi
force-pushed
the
mi_fwd_model
branch
from
e8041a5 to
9234584
Compare
…nd create properties for non_defualt_arguments
amal-ghamdi
force-pushed
the
mi_fwd_model
branch
from
405bcb1 to
044e58c
Compare
…d_with_new_parameter_names
nabriis
reviewed
Feb 4, 2025
There was a problem hiding this comment.
From live review of code
- Printing looks a bit strange for Model. Maybe use specific case for ProductGeometry?
- Can you check that if we pass in CUQIArray but say its funval/parameters what happens? Works as intended?
- Related to stacking. Do we have good docstring to explain this option? Should we ask for user to provide e.g. "is_stacked".
- What about Samples in the Dict? Why is the stacked samples not support?
- Check that given RVs x, y, z, that F(x, y, z) works.
- Look into gradient as None. Do we need it now? Seems to change behavior. Maybe we return error?
- Gradient as stacked. Look into "is_stacked" parameter.
- Look into stacked output.
- Look into if Model should be two classes or one?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #605
Notes about reviewing: see issue description