Skip to content

Commit

Permalink
Input: edt_ft5x06 - change msleep to usleep_range for small msecs
Browse files Browse the repository at this point in the history
msleep(1~20) may not do what the caller intends, and will often sleep
longer (~20 ms actual sleep for any value given in the 1~20ms range).  This
is not the desired behaviour for many cases like device resume time, device
suspend time, device enable time, retry logic, etc.  Thus, change msleep to
usleep_range for precise wakeups.

Signed-off-by: Aniroop Mathur <[email protected]>
Acked-by: Simon Budig <[email protected]>
Signed-off-by: Dmitry Torokhov <[email protected]>
  • Loading branch information
Aniroop Mathur authored and dtor committed Jan 6, 2017
1 parent c01b5e7 commit 0eeecf6
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/input/touchscreen/edt-ft5x06.c
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@
#define EDT_SWITCH_MODE_RETRIES 10
#define EDT_SWITCH_MODE_DELAY 5 /* msec */
#define EDT_RAW_DATA_RETRIES 100
#define EDT_RAW_DATA_DELAY 1 /* msec */
#define EDT_RAW_DATA_DELAY 1000 /* usec */

enum edt_ver {
M06,
Expand Down Expand Up @@ -664,7 +664,7 @@ static ssize_t edt_ft5x06_debugfs_raw_data_read(struct file *file,
}

do {
msleep(EDT_RAW_DATA_DELAY);
usleep_range(EDT_RAW_DATA_DELAY, EDT_RAW_DATA_DELAY + 100);
val = edt_ft5x06_register_read(tsdata, 0x08);
if (val < 1)
break;
Expand Down

0 comments on commit 0eeecf6

Please sign in to comment.