Skip to content

Commit

Permalink
befs: fix style issues in header files
Browse files Browse the repository at this point in the history
Fixing checkpatch.pl issues in befs header files:
WARNING: Missing a blank line after declarations
+       befs_inode_addr iaddr;
+       iaddr.allocation_group = blockno >> BEFS_SB(sb)->ag_shift;

WARNING: space prohibited between function name and open parenthesis '('
+       return BEFS_SB(sb)->block_size / sizeof (befs_disk_inode_addr);

ERROR: "foo * bar" should be "foo *bar"
+                   const char *key, befs_off_t * value);

ERROR: Macros with complex values should be enclosed in parentheses
+#define PACKED __attribute__ ((__packed__))

Signed-off-by: Luis de Bethencourt <[email protected]>
  • Loading branch information
luisbg committed Dec 22, 2016
1 parent 62b8071 commit 12ecb38
Show file tree
Hide file tree
Showing 6 changed files with 12 additions and 17 deletions.
3 changes: 2 additions & 1 deletion fs/befs/befs.h
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,7 @@ static inline befs_inode_addr
blockno2iaddr(struct super_block *sb, befs_blocknr_t blockno)
{
befs_inode_addr iaddr;

iaddr.allocation_group = blockno >> BEFS_SB(sb)->ag_shift;
iaddr.start =
blockno - (iaddr.allocation_group << BEFS_SB(sb)->ag_shift);
Expand All @@ -140,7 +141,7 @@ blockno2iaddr(struct super_block *sb, befs_blocknr_t blockno)
static inline unsigned int
befs_iaddrs_per_block(struct super_block *sb)
{
return BEFS_SB(sb)->block_size / sizeof (befs_disk_inode_addr);
return BEFS_SB(sb)->block_size / sizeof(befs_disk_inode_addr);
}

#include "endian.h"
Expand Down
8 changes: 4 additions & 4 deletions fs/befs/befs_fs_types.h
Original file line number Diff line number Diff line change
Expand Up @@ -55,12 +55,12 @@ enum super_flags {
};

#define BEFS_BYTEORDER_NATIVE 0x42494745
#define BEFS_BYTEORDER_NATIVE_LE (__force fs32)cpu_to_le32(BEFS_BYTEORDER_NATIVE)
#define BEFS_BYTEORDER_NATIVE_BE (__force fs32)cpu_to_be32(BEFS_BYTEORDER_NATIVE)
#define BEFS_BYTEORDER_NATIVE_LE ((__force fs32)cpu_to_le32(BEFS_BYTEORDER_NATIVE))
#define BEFS_BYTEORDER_NATIVE_BE ((__force fs32)cpu_to_be32(BEFS_BYTEORDER_NATIVE))

#define BEFS_SUPER_MAGIC BEFS_SUPER_MAGIC1
#define BEFS_SUPER_MAGIC1_LE (__force fs32)cpu_to_le32(BEFS_SUPER_MAGIC1)
#define BEFS_SUPER_MAGIC1_BE (__force fs32)cpu_to_be32(BEFS_SUPER_MAGIC1)
#define BEFS_SUPER_MAGIC1_LE ((__force fs32)cpu_to_le32(BEFS_SUPER_MAGIC1))
#define BEFS_SUPER_MAGIC1_BE ((__force fs32)cpu_to_be32(BEFS_SUPER_MAGIC1))

/*
* Flags of inode
Expand Down
6 changes: 2 additions & 4 deletions fs/befs/btree.h
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,9 @@
*
*/


int befs_btree_find(struct super_block *sb, const befs_data_stream *ds,
const char *key, befs_off_t * value);
const char *key, befs_off_t *value);

int befs_btree_read(struct super_block *sb, const befs_data_stream *ds,
loff_t key_no, size_t bufsize, char *keybuf,
size_t * keysize, befs_off_t * value);

size_t *keysize, befs_off_t *value);
5 changes: 2 additions & 3 deletions fs/befs/datastream.h
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@

struct buffer_head *befs_read_datastream(struct super_block *sb,
const befs_data_stream *ds,
befs_off_t pos, uint * off);
befs_off_t pos, uint *off);

int befs_fblock2brun(struct super_block *sb, const befs_data_stream *data,
befs_blocknr_t fblock, befs_block_run * run);
befs_blocknr_t fblock, befs_block_run *run);

size_t befs_read_lsymlink(struct super_block *sb, const befs_data_stream *data,
void *buff, befs_off_t len);
Expand All @@ -17,4 +17,3 @@ befs_blocknr_t befs_count_blocks(struct super_block *sb,
const befs_data_stream *ds);

extern const befs_inode_addr BAD_IADDR;

3 changes: 1 addition & 2 deletions fs/befs/inode.h
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,5 @@
*
*/

int befs_check_inode(struct super_block *sb, befs_inode * raw_inode,
int befs_check_inode(struct super_block *sb, befs_inode *raw_inode,
befs_blocknr_t inode);

4 changes: 1 addition & 3 deletions fs/befs/super.h
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,5 @@
* super.h
*/

int befs_load_sb(struct super_block *sb, befs_super_block * disk_sb);

int befs_load_sb(struct super_block *sb, befs_super_block *disk_sb);
int befs_check_sb(struct super_block *sb);

0 comments on commit 12ecb38

Please sign in to comment.