Skip to content

Commit

Permalink
fs: convert __generic_file_fsync to use errseq_t based reporting
Browse files Browse the repository at this point in the history
Many simple, block-based filesystems use generic_file_fsync as their
fsync operation. Some others (ext* and fat) also call this function
to handle syncing out data.

Switch this code over to use errseq_t based error reporting so that
all of these filesystems get reliable error reporting via fsync,
fdatasync and msync.

Signed-off-by: Jeff Layton <[email protected]>
  • Loading branch information
jtlayton committed Jul 6, 2017
1 parent 372cf24 commit 383aa54
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions fs/libfs.c
Original file line number Diff line number Diff line change
Expand Up @@ -974,7 +974,7 @@ int __generic_file_fsync(struct file *file, loff_t start, loff_t end,
int err;
int ret;

err = filemap_write_and_wait_range(inode->i_mapping, start, end);
err = file_write_and_wait_range(file, start, end);
if (err)
return err;

Expand All @@ -991,9 +991,11 @@ int __generic_file_fsync(struct file *file, loff_t start, loff_t end,

out:
inode_unlock(inode);
/* must call this unconditionally as it clears AS_* error flags */
err = filemap_check_errors(inode->i_mapping);
return ret ? ret : err;
/* check and advance again to catch errors after syncing out buffers */
err = file_check_and_advance_wb_err(file);
if (ret == 0)
ret = err;
return ret;
}
EXPORT_SYMBOL(__generic_file_fsync);

Expand Down

0 comments on commit 383aa54

Please sign in to comment.