Skip to content

Commit

Permalink
tipc: kill unnecessary goto's
Browse files Browse the repository at this point in the history
Remove a number of needless 'goto exit' in send_stream
when the socket is in an unconnected state.
This patch is cosmetic and does not alter the operation of
TIPC in any way.

Reviewed-by: Jon Maloy <[email protected]>
Reviewed-by: Erik Hugne <[email protected]>
Signed-off-by: Wang Weidong <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
  • Loading branch information
wangweidong authored and davem330 committed Dec 16, 2013
1 parent 0cee6bb commit 3b8401f
Showing 1 changed file with 6 additions and 8 deletions.
14 changes: 6 additions & 8 deletions net/tipc/socket.c
Original file line number Diff line number Diff line change
Expand Up @@ -751,16 +751,14 @@ static int send_stream(struct kiocb *iocb, struct socket *sock,

/* Handle special cases where there is no connection */
if (unlikely(sock->state != SS_CONNECTED)) {
if (sock->state == SS_UNCONNECTED) {
res = -ENOTCONN;

if (sock->state == SS_UNCONNECTED)
res = send_packet(NULL, sock, m, total_len);
goto exit;
} else if (sock->state == SS_DISCONNECTING) {
else if (sock->state == SS_DISCONNECTING)
res = -EPIPE;
goto exit;
} else {
res = -ENOTCONN;
goto exit;
}

goto exit;
}

if (unlikely(m->msg_name)) {
Expand Down

0 comments on commit 3b8401f

Please sign in to comment.