Skip to content

Commit

Permalink
parisc: Fix automatic selection of cr16 clocksource
Browse files Browse the repository at this point in the history
Commit 54b6680 (parisc: Add native high-resolution sched_clock()
implementation) added support to use the CPU-internal cr16 counters as reliable
clocksource with the help of HAVE_UNSTABLE_SCHED_CLOCK.

Sadly the commit missed to remove the hack which prevented cr16 to become the
default clocksource even on SMP systems.

Signed-off-by: Helge Deller <[email protected]>
Cc: [email protected] # 4.7+
  • Loading branch information
hdeller committed Aug 20, 2016
1 parent 6040e57 commit ae14183
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 20 deletions.
8 changes: 0 additions & 8 deletions arch/parisc/kernel/processor.c
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,6 @@ EXPORT_SYMBOL(_parisc_requires_coherency);

DEFINE_PER_CPU(struct cpuinfo_parisc, cpu_data);

extern int update_cr16_clocksource(void); /* from time.c */

/*
** PARISC CPU driver - claim "device" and initialize CPU data structures.
**
Expand Down Expand Up @@ -228,12 +226,6 @@ static int processor_probe(struct parisc_device *dev)
}
#endif

/* If we've registered more than one cpu,
* we'll use the jiffies clocksource since cr16
* is not synchronized between CPUs.
*/
update_cr16_clocksource();

return 0;
}

Expand Down
12 changes: 0 additions & 12 deletions arch/parisc/kernel/time.c
Original file line number Diff line number Diff line change
Expand Up @@ -221,18 +221,6 @@ static struct clocksource clocksource_cr16 = {
.flags = CLOCK_SOURCE_IS_CONTINUOUS,
};

int update_cr16_clocksource(void)
{
/* since the cr16 cycle counters are not synchronized across CPUs,
we'll check if we should switch to a safe clocksource: */
if (clocksource_cr16.rating != 0 && num_online_cpus() > 1) {
clocksource_change_rating(&clocksource_cr16, 0);
return 1;
}

return 0;
}

void __init start_cpu_itimer(void)
{
unsigned int cpu = smp_processor_id();
Expand Down

0 comments on commit ae14183

Please sign in to comment.