Skip to content

Commit

Permalink
mac80211: uninitialized return val in __ieee80211_sta_handle_tspec_ac…
Browse files Browse the repository at this point in the history
…_params

The return value should be initialized to false so that there's a
valid return value when there are no sessions that need work to be
done on them. Luckily, the side effect of using the uninitialized
value is an extra harmless driver call.

Coverity: CID 1260096
Fixes: 02219b3 ("mac80211: add WMM admission control support")
Signed-off-by: John W. Linville <[email protected]>
[extend commit message]
Signed-off-by: Johannes Berg <[email protected]>
  • Loading branch information
linvjw authored and jmberg-intel committed Jan 7, 2015
1 parent 1e359a5 commit cc72f6e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion net/mac80211/mlme.c
Original file line number Diff line number Diff line change
Expand Up @@ -1643,7 +1643,7 @@ __ieee80211_sta_handle_tspec_ac_params(struct ieee80211_sub_if_data *sdata)
{
struct ieee80211_local *local = sdata->local;
struct ieee80211_if_managed *ifmgd = &sdata->u.mgd;
bool ret;
bool ret = false;
int ac;

if (local->hw.queues < IEEE80211_NUM_ACS)
Expand Down

0 comments on commit cc72f6e

Please sign in to comment.