Skip to content

Commit

Permalink
ASoC: atmel-pdmic: Simplify use of devm_ioremap_resource
Browse files Browse the repository at this point in the history
Remove unneeded error handling on the result of a call to
platform_get_resource when the value is passed to
devm_ioremap_resource.

The Coccinelle semantic patch that makes this change is as follows:

// <smpl>
@@
expression pdev,res,n,e,e1;
expression ret != 0;
identifier l;
@@

- res = platform_get_resource(pdev, IORESOURCE_MEM, n);
  ... when != res
- if (res == NULL) { ... \(goto l;\|return ret;\) }
  ... when != res
+ res = platform_get_resource(pdev, IORESOURCE_MEM, n);
  e = devm_ioremap_resource(e1, res);
// </smpl>

Signed-off-by: Amitoj Kaur Chawla <[email protected]>
Signed-off-by: Mark Brown <[email protected]>
  • Loading branch information
musicakc authored and broonie committed Jul 4, 2016
1 parent 2d3c7e0 commit fef5b2b
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions sound/soc/atmel/atmel-pdmic.c
Original file line number Diff line number Diff line change
Expand Up @@ -624,11 +624,6 @@ static int atmel_pdmic_probe(struct platform_device *pdev)
}

res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
if (!res) {
dev_err(dev, "no memory resource\n");
return -ENXIO;
}

io_base = devm_ioremap_resource(dev, res);
if (IS_ERR(io_base)) {
ret = PTR_ERR(io_base);
Expand Down

0 comments on commit fef5b2b

Please sign in to comment.