Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ feat(manifest): Add a manifest file #193

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

✨ feat(manifest): Add a manifest file #193

wants to merge 19 commits into from

Conversation

dylanmsql
Copy link
Contributor

@dylanmsql dylanmsql commented May 9, 2023 •
edited
Loading

Pull request for Candy-doc

Your checklist for this pull request

🚨 Please review the guidelines for contributing to
this repository.

  • Make sure you are requesting to pull a feature/bugfix branch (right
    side). Don't request your master!
  • Make sure you are making a pull request against the main branch (left
    side).
  • Check the commit's or even all commits' message styles matches our
    requested structure.
  • Check your code additions will fail neither code linting checks nor unit
    test.

Description

Please describe your pull request.

❤️ Thank you!

@dylanmsql dylanmsql requested a review from ecattez as a code owner May 9, 2023 12:56
@dylanmsql dylanmsql requested a review from monxxi May 9, 2023 14:31
@dylanmsql dylanmsql linked an issue May 9, 2023 that may be closed by this pull request
Create a Manifest to indicates the json files to the CLI #190
Open
ecattez
ecattez requested changes May 10, 2023
View reviewed changes
src/test/resources/json/MANIFEST_bounded_context_one.json Outdated Show resolved Hide resolved
src/main/java/io/candydoc/plugin/save_ubiquitous_language/file/UbiquitousLanguageAsFile.java Outdated Show resolved Hide resolved
src/main/java/io/candydoc/plugin/save_ubiquitous_language/file/UbiquitousLanguageAsFile.java Outdated Show resolved Hide resolved
src/main/java/io/candydoc/plugin/save_ubiquitous_language/file/UbiquitousLanguageAsFile.java Outdated Show resolved Hide resolved
src/main/java/io/candydoc/plugin/save_ubiquitous_language/file/UbiquitousLanguageAsFile.java Outdated Show resolved Hide resolved
src/main/java/io/candydoc/plugin/save_ubiquitous_language/file/UbiquitousLanguageAsFile.java Outdated Show resolved Hide resolved
...java/io/candydoc/plugin/save_ubiquitous_language/file/json/UbiquitousLanguageAsJsonTest.java Outdated Show resolved Hide resolved
@Yugo-Cartron Yugo-Cartron requested a review from ecattez May 11, 2023 12:55
@Yugo-Cartron Yugo-Cartron self-requested a review June 6, 2023 08:34
Yugo-Cartron
Yugo-Cartron previously approved these changes Jun 6, 2023
View reviewed changes
@dylanmsql dylanmsql requested a review from ecattez June 12, 2023 12:22
@dylanmsql dylanmsql requested a review from ecattez July 11, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monxxi monxxi monxxi left review comments

@Yugo-Cartron Yugo-Cartron Yugo-Cartron left review comments

@ecattez ecattez Awaiting requested review from ecattez ecattez is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a Manifest to indicates the json files to the CLI
4 participants
@dylanmsql @ecattez @monxxi @Yugo-Cartron