Merge pull request #11 from CarbonPHP/feature/stricter-types

Make interface types strict
CarbonPHP · Apr 7, 2024 · 9098d1c · 9098d1c
2 parents 18ba5dd + 5d99dc8
commit 9098d1c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/src/Carbon/Doctrine/CarbonDoctrineType.php b/src/Carbon/Doctrine/CarbonDoctrineType.php
@@ -4,13 +4,14 @@
 
 namespace Carbon\Doctrine;
 
+use Carbon\CarbonInterface;
 use Doctrine\DBAL\Platforms\AbstractPlatform;
 
 interface CarbonDoctrineType
 {
-    public function getSQLDeclaration(array $fieldDeclaration, AbstractPlatform $platform);
+    public function getSQLDeclaration(array $fieldDeclaration, AbstractPlatform $platform): string;
 
-    public function convertToPHPValue(mixed $value, AbstractPlatform $platform);
+    public function convertToPHPValue(mixed $value, AbstractPlatform $platform): ?CarbonInterface;
 
-    public function convertToDatabaseValue($value, AbstractPlatform $platform);
+    public function convertToDatabaseValue(mixed $value, AbstractPlatform $platform): ?string;
 }
diff --git a/src/Carbon/Doctrine/CarbonTypeConverter.php b/src/Carbon/Doctrine/CarbonTypeConverter.php
@@ -62,7 +62,7 @@ public function getSQLDeclaration(array $fieldDeclaration, AbstractPlatform $pla
     /**
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
-    public function convertToDatabaseValue($value, AbstractPlatform $platform): ?string
+    public function convertToDatabaseValue(mixed $value, AbstractPlatform $platform): ?string
     {
         if ($value === null) {
             return $value;
@@ -79,7 +79,7 @@ public function convertToDatabaseValue($value, AbstractPlatform $platform): ?str
         );
     }
 
-    private function doConvertToPHPValue(mixed $value)
+    private function doConvertToPHPValue(mixed $value): ?CarbonInterface
     {
         $class = $this->getCarbonClassName();