Skip to content

Commit

Permalink
net: sctp: prevent writes to cookie_hmac_alg from accessing invalid m…
Browse files Browse the repository at this point in the history
…emory

proc_dostring() needs an initialized destination string, while the one
provided in proc_sctp_do_hmac_alg() contains stack garbage.

Thus, writing to cookie_hmac_alg would strlen() that garbage and end up
accessing invalid memory.

Fixes: 3c68198 ("sctp: Make hmac algorithm selection for cookie generation dynamic")
Signed-off-by: Sasha Levin <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
  • Loading branch information
sashalevin authored and davem330 committed Jan 10, 2016
1 parent 18715b2 commit 320f1a4
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion net/sctp/sysctl.c
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,7 @@ static int proc_sctp_do_hmac_alg(struct ctl_table *ctl, int write,
struct ctl_table tbl;
bool changed = false;
char *none = "none";
char tmp[8];
char tmp[8] = {0};
int ret;

memset(&tbl, 0, sizeof(struct ctl_table));
Expand Down

0 comments on commit 320f1a4

Please sign in to comment.