Skip to content

Commit

Permalink
utilities: install ovs-lib.sh as data not a script
Browse files Browse the repository at this point in the history
Currently, ovs-lib.sh is installed as an executable.  It's meant to be
sourced by external scripts, so install as data.  Fixes rpmlint error:

 E: script-without-shebang /usr/share/openvswitch/scripts/ovs-lib.sh

Could drop the .sh suffix in another commit.

Signed-off-by: Chris Wright <[email protected]>
Signed-off-by: Ben Pfaff <[email protected]>
  • Loading branch information
chriswright authored and blp committed Dec 9, 2011
1 parent 186ef5c commit 429ebf2
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
2 changes: 2 additions & 0 deletions Makefile.am
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ dist_pkgdata_DATA =
dist_pkgdata_SCRIPTS =
dist_sbin_SCRIPTS =
dist_scripts_SCRIPTS =
dist_scripts_DATA =
INSTALL_DATA_LOCAL =
UNINSTALL_LOCAL =
man_MANS =
Expand All @@ -74,6 +75,7 @@ OVSIDL_BUILT =
pkgdata_DATA =
sbin_SCRIPTS =
scripts_SCRIPTS =
scripts_DATA =
SUFFIXES =
check_DATA =

Expand Down
3 changes: 2 additions & 1 deletion utilities/automake.mk
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@ bin_SCRIPTS += \
utilities/ovs-vlan-test
endif
noinst_SCRIPTS += utilities/ovs-pki-cgi
scripts_SCRIPTS += utilities/ovs-ctl utilities/ovs-lib.sh utilities/ovs-save
scripts_SCRIPTS += utilities/ovs-ctl utilities/ovs-save
scripts_DATA += utilities/ovs-lib.sh

EXTRA_DIST += \
utilities/ovs-ctl.in \
Expand Down

0 comments on commit 429ebf2

Please sign in to comment.