ofproto: Rate-limit STP status errors on non-existent ports.

As part of the bridge's main loop, it queries the STP status of all ports. If the port doesn't exist, log files can become filled with warning messages. This situation is very unusual, since system devices do not normally disappear, but it's easy enough to rate-limit these messages. Bug #10936 Reported-by: Reid Price <[email protected]> Signed-off-by: Justin Pettit <[email protected]>
Cartmanfku · May 2, 2012 · b0a5c43 · b0a5c43
1 parent f66b87d
commit b0a5c43
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c
@@ -664,8 +664,8 @@ ofproto_port_get_stp_status(struct ofproto *ofproto, uint16_t ofp_port,
 {
     struct ofport *ofport = ofproto_get_port(ofproto, ofp_port);
     if (!ofport) {
-        VLOG_WARN("%s: cannot get STP status on nonexistent port %"PRIu16,
-                  ofproto->name, ofp_port);
+        VLOG_WARN_RL(&rl, "%s: cannot get STP status on nonexistent "
+                     "port %"PRIu16, ofproto->name, ofp_port);
         return ENODEV;
     }