Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New named sources example #29

Merged
merged 2 commits into from
Dec 9, 2024
Merged

New named sources example #29

merged 2 commits into from
Dec 9, 2024

Conversation

srtena
Copy link
Contributor

@srtena srtena commented Nov 22, 2024

Adds a new example for the Named Sources release. It uses the query-accidents example as a base, and simply replaces the SQL queries there by named sources to prevent exposing the SQL in the application.

  • Updated readme
  • Updated code
  • Example uses the public organization and the right token

@srtena srtena self-assigned this Nov 22, 2024
Copy link
Member

@donmccurdy donmccurdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, code looks readable and clean!

new VectorTileLayer({
id: 'accidents_by_state',
data: accidentsByState,
pickable: true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor - layer is marked pickable but we're not doing anything with the click events, is this needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed! Thanks

@srtena srtena merged commit ee9a3b2 into master Dec 9, 2024
@srtena srtena deleted the named-sources-example branch December 9, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants