remove Web test blacklist; all tests should pass now (flutter#11640)

* copy ahem.ttf where web_ui can find it * remove Web test blacklist; all tests should pass now
CaseyHillers · Aug 28, 2019 · 479719b · 479719b
1 parent 728ff71
commit 479719b
Showing 1 changed file with 9 additions and 7 deletions.
diff --git a/lib/web_ui/dev/test.dart b/lib/web_ui/dev/test.dart
@@ -74,18 +74,13 @@ List<io.File> _flatListSourceFiles(io.Directory directory) {
 }
 
 Future<void> _runTests() async {
-  // TODO(yjbanov): make the following tests pass.
-  const List<String> testBlacklist = <String>[
-    'test/text/measurement_test.dart',
-    'test/paragraph_test.dart',
-    'test/text_test.dart',
-  ];
+  _copyAhemFontIntoWebUi();
 
   final List<String> testFiles = io.Directory('test')
     .listSync(recursive: true)
     .whereType<io.File>()
     .map<String>((io.File file) => file.path)
-    .where((String path) => path.endsWith('_test.dart') && !testBlacklist.contains(path))
+    .where((String path) => path.endsWith('_test.dart'))
     .toList();
 
   final io.Process pubRunTest = await io.Process.start(
@@ -111,6 +106,12 @@ Future<void> _runTests() async {
   }
 }
 
+void _copyAhemFontIntoWebUi() {
+  final io.File sourceAhemTtf = io.File(pathlib.join(environment.flutterDirectory.path, 'third_party', 'txt', 'third_party', 'fonts', 'ahem.ttf'));
+  final String destinationAhemTtfPath = pathlib.join(environment.webUiRootDir.path, 'lib', 'assets', 'ahem.ttf');
+  sourceAhemTtf.copySync(destinationAhemTtfPath);
+}
+
 class Environment {
   factory Environment() {
     final io.File self = io.File.fromUri(io.Platform.script);
@@ -157,6 +158,7 @@ class Environment {
   final String dartExecutable;
 
   String get pubExecutable => pathlib.join(dartSdkDir.path, 'bin', 'pub');
+  io.Directory get flutterDirectory => io.Directory(pathlib.join(engineSrcDir.path, 'flutter'));
 
   @override
   String toString() {