chore(app, platforms): remove facebook stamp (passportxyz#2003)

CaseyKing11 · Dec 26, 2023 · a30fe1e · a30fe1e
1 parent b7bb11f
commit a30fe1e
Show file tree

Hide file tree

Showing 21 changed files with 9 additions and 1,082 deletions.
diff --git a/app/.env-example.env b/app/.env-example.env
@@ -3,7 +3,6 @@ NEXT_PUBLIC_PASSPORT_GOOGLE_CLIENT_ID=MY-APP-ID.apps.googleusercontent.com
 NEXT_PUBLIC_PASSPORT_GOOGLE_CALLBACK=http://localhost:3000/
 
 NEXT_PUBLIC_PASSPORT_TWITTER_CLIENT_ID=ABC123456789
-NEXT_PUBLIC_PASSPORT_FACEBOOK_APP_ID=123456789
 NEXT_PUBLIC_PASSPORT_GITHUB_CLIENT_ID=12345678
 NEXT_PUBLIC_PASSPORT_GITHUB_CALLBACK=http://localhost:3000/
 NEXT_PUBLIC_PASSPORT_LINKEDIN_CLIENT_ID=12345678

diff --git a/app/__test-fixtures__/contextTestHelpers.tsx b/app/__test-fixtures__/contextTestHelpers.tsx
@@ -46,14 +46,6 @@ export const makeTestCeramicContext = (initialState?: Partial<CeramicContextStat
         providerSpec: getProviderSpec("POAP", "POAP"),
         stamp: undefined,
       },
-      Facebook: {
-        providerSpec: getProviderSpec("Facebook", "Facebook"),
-        stamp: undefined,
-      },
-      FacebookProfilePicture: {
-        providerSpec: getProviderSpec("Facebook", "FacebookProfilePicture"),
-        stamp: undefined,
-      },
       Brightid: {
         providerSpec: getProviderSpec("Brightid", "Brightid"),
         stamp: undefined,

diff --git a/app/__test-fixtures__/databaseStorageFixtures.ts b/app/__test-fixtures__/databaseStorageFixtures.ts
@@ -46,11 +46,6 @@ export const twitterStampFixture: Stamp = {
   credential,
 };
 
-export const facebookStampFixture: Stamp = {
-  provider: "Facebook",
-  credential,
-};
-
 export const brightidStampFixture: Stamp = {
   provider: "Brightid",
   credential,

diff --git a/app/__tests__/components/ProviderCards/FacebookCard.test.tsx b/app/__tests__/components/ProviderCards/FacebookCard.test.tsx
diff --git a/app/__tests__/context/ceramicContext.test.tsx b/app/__tests__/context/ceramicContext.test.tsx
@@ -11,7 +11,6 @@ import {
   googleStampFixture,
   discordStampFixture,
   brightidStampFixture,
-  facebookStampFixture,
 } from "../../__test-fixtures__/databaseStorageFixtures";
 import { Passport } from "@gitcoin/passport-types";
 import {
@@ -59,7 +58,7 @@ export const dbDeleteStampMock = jest.fn();
 export const dbDeleteStampsMock = jest.fn();
 export const dbCreatePassportMock = jest.fn();
 
-const stamps = [googleStampFixture, discordStampFixture, brightidStampFixture, facebookStampFixture].map((stamp) => {
+const stamps = [googleStampFixture, discordStampFixture, brightidStampFixture].map((stamp) => {
   stamp.credential.expirationDate = "2099-05-15T21:04:01.708Z";
   stamp.credential.credentialSubject.id = "test-user-did";
   stamp.credential.issuer = process.env.NEXT_PUBLIC_PASSPORT_IAM_ISSUER_DID || "";
@@ -145,12 +144,12 @@ describe("CeramicContextProvider syncs stamp state with ceramic", () => {
     });
     render(mockComponent());
 
-    await waitFor(() => expect(screen.getAllByText("# Stamps = 4")).toHaveLength(1));
+    await waitFor(() => expect(screen.getAllByText("# Stamps = 3")).toHaveLength(1));
   });
   it("should clean a dirty passport after successful fetch", async () => {
     const expiredStamp = {
-      ...facebookStampFixture,
-      credential: { ...facebookStampFixture.credential, expirationDate: "2021-05-15T21:04:01.708Z" },
+      ...googleStampFixture,
+      credential: { ...googleStampFixture.credential, expirationDate: "2021-05-15T21:04:01.708Z" },
     };
     (PassportDatabase as jest.Mock).mockImplementation(() => {
       return {
@@ -168,7 +167,7 @@ describe("CeramicContextProvider syncs stamp state with ceramic", () => {
     });
     render(mockComponent());
 
-    await waitFor(() => expect(screen.getAllByText("# Stamps = 4")).toHaveLength(1));
+    await waitFor(() => expect(screen.getAllByText("# Stamps = 3")).toHaveLength(1));
   });
   it("should set passport to undefined if an exception is raised while fetching", async () => {
     (PassportDatabase as jest.Mock).mockImplementationOnce(() => {
@@ -227,7 +226,7 @@ describe("CeramicContextProvider syncs stamp state with ceramic", () => {
     });
     render(mockComponent());
 
-    await waitFor(() => expect(screen.getAllByText("# Stamps = 4")).toHaveLength(1));
+    await waitFor(() => expect(screen.getAllByText("# Stamps = 3")).toHaveLength(1));
   });
 
   it("should attempt to add stamps to database and ceramic", async () => {
@@ -454,7 +453,7 @@ const mockDatabase = {
 } as PassportDatabase;
 const mockProvidersState = {
   google: true,
-  facebook: true,
+  ens: true,
 } as AllProvidersState;
 
 describe("cleanPassport function", () => {
@@ -477,7 +476,7 @@ describe("cleanPassport function", () => {
     const validStamp = {
       credential: {
         expirationDate: "2099-05-15T21:04:01.708Z",
-        credentialSubject: { provider: "facebook", id: "test-user-did" },
+        credentialSubject: { provider: "google", id: "test-user-did" },
         issuer: process.env.NEXT_PUBLIC_PASSPORT_IAM_ISSUER_DID || "",
       },
     };

diff --git a/app/config/filters.ts b/app/config/filters.ts
@@ -13,7 +13,6 @@ export const STAMP_FILTERS: {
       Ens: ["Account Name"],
       Poh: ["Account Name"],
       Twitter: ["Account Name"],
-      Facebook: ["Account Name"],
       Brightid: ["Account Name"],
       Linkedin: ["Account Name"],
       Discord: ["Account Name"],

diff --git a/app/context/ceramicContext.tsx b/app/context/ceramicContext.tsx
@@ -23,7 +23,6 @@ const {
   Lens,
   Github,
   Gitcoin,
-  Facebook,
   Poh,
   PHI,
   NFT,
@@ -89,11 +88,6 @@ platforms.set("NFT", {
   platFormGroupSpec: NFT.ProviderConfig,
 });
 
-platforms.set("Facebook", {
-  platform: new Facebook.FacebookPlatform(),
-  platFormGroupSpec: Facebook.ProviderConfig,
-});
-
 platforms.set("Github", {
   platform: new Github.GithubPlatform({
     clientId: process.env.NEXT_PUBLIC_PASSPORT_GITHUB_CLIENT_ID,

diff --git a/app/pages/_app.tsx b/app/pages/_app.tsx
@@ -23,7 +23,6 @@ import TagManager from "react-gtm-module";
 import { themes, ThemeWrapper } from "../utils/theme";
 import { StampClaimingContextProvider } from "../context/stampClaimingContext";
 
-const FacebookAppId = process.env.NEXT_PUBLIC_PASSPORT_FACEBOOK_APP_ID || "";
 const GTM_ID = process.env.NEXT_PUBLIC_GOOGLE_TAG_MANAGER_ID || "";
 const INTERCOM_APP_ID = process.env.NEXT_PUBLIC_INTERCOM_APP_ID || "";
 
@@ -137,39 +136,11 @@ function App({ Component, pageProps }: AppProps) {
     }
   }
 
-  const facebookSdkScript = (
-    <script
-      id="facebook-app-script"
-      dangerouslySetInnerHTML={{
-        __html: `
-          window.fbAsyncInit = function() {
-            FB.init({
-              appId      : '${FacebookAppId}',
-              cookie     : true,
-              xfbml      : true,
-              version    : 'v13.0'
-            });
-            FB.AppEvents.logPageView();
-          };
-
-          (function(d, s, id){
-            var js, fjs = d.getElementsByTagName(s)[0];
-            if (d.getElementById(id)) {return;}
-            js = d.createElement(s); js.id = id;
-            js.src = "https://connect.facebook.net/en_US/sdk.js";
-            fjs.parentNode.insertBefore(js, fjs);
-          }(document, 'script', 'facebook-jssdk'));
-        `,
-      }}
-    />
-  );
-
   return (
     <>
       <Head>
         <link rel="shortcut icon" href="/favicon.ico" />
         <title>Gitcoin Passport</title>
-        {facebookSdkScript}
         <meta name="viewport" content="width=device-width, initial-scale=1.0, minimum-scale=1.0" />
       </Head>
       <SelfIdProvider

diff --git a/iam/.env-example.env b/iam/.env-example.env
@@ -6,8 +6,6 @@ GOOGLE_CALLBACK=http://localhost:3000/
 TWITTER_CLIENT_ID=MY-APP-ID-TWITTER
 TWITTER_CLIENT_SECRET=MY_APP_SECRET
 TWITTER_CALLBACK=http://127.0.0.1:3000/
-FACEBOOK_APP_ID=MY_APP_ID
-FACEBOOK_APP_SECRET=MY_APP_SECRET
 BRIGHTID_PRIVATE_KEY=BRIGHTID_PRIVATE_KEY
 GITHUB_CLIENT_ID=MY_GITHUB_CLIENT_ID
 GITHUB_CLIENT_SECRET=MY_GITHUB_CLIENT_SECRET

diff --git a/infra/aws/iam_secrets.ts b/infra/aws/iam_secrets.ts
@@ -1,6 +1,4 @@
-
-
-export const getIamSecrets = (PASSPORT_VC_SECRETS_ARN:string, IAM_SERVER_SSM_ARN:string) => [
+export const getIamSecrets = (PASSPORT_VC_SECRETS_ARN: string, IAM_SERVER_SSM_ARN: string) => [
   {
     name: "IAM_JWK",
     valueFrom: `${PASSPORT_VC_SECRETS_ARN}:IAM_JWK::`,
@@ -37,14 +35,6 @@ export const getIamSecrets = (PASSPORT_VC_SECRETS_ARN:string, IAM_SERVER_SSM_ARN
     name: "TWITTER_CLIENT_SECRET",
     valueFrom: `${IAM_SERVER_SSM_ARN}:TWITTER_CLIENT_SECRET::`,
   },
-  {
-    name: "FACEBOOK_APP_ID",
-    valueFrom: `${IAM_SERVER_SSM_ARN}:FACEBOOK_APP_ID::`,
-  },
-  {
-    name: "FACEBOOK_APP_SECRET",
-    valueFrom: `${IAM_SERVER_SSM_ARN}:FACEBOOK_APP_SECRET::`,
-  },
   {
     name: "BRIGHTID_PRIVATE_KEY",
     valueFrom: `${IAM_SERVER_SSM_ARN}:BRIGHTID_PRIVATE_KEY::`,

diff --git a/infra/production/index.ts b/infra/production/index.ts
@@ -211,14 +211,6 @@ const service = new awsx.ecs.FargateService("dpopp-iam", {
             name: "TWITTER_CLIENT_SECRET",
             valueFrom: `${IAM_SERVER_SSM_ARN}:TWITTER_CLIENT_SECRET::`,
           },
-          {
-            name: "FACEBOOK_APP_ID",
-            valueFrom: `${IAM_SERVER_SSM_ARN}:FACEBOOK_APP_ID::`,
-          },
-          {
-            name: "FACEBOOK_APP_SECRET",
-            valueFrom: `${IAM_SERVER_SSM_ARN}:FACEBOOK_APP_SECRET::`,
-          },
           {
             name: "BRIGHTID_PRIVATE_KEY",
             valueFrom: `${IAM_SERVER_SSM_ARN}:BRIGHTID_PRIVATE_KEY::`,

diff --git a/infra/review/index.ts b/infra/review/index.ts
@@ -206,14 +206,6 @@ const service = new awsx.ecs.FargateService("dpopp-iam", {
             name: "TWITTER_CLIENT_SECRET",
             valueFrom: `${IAM_SERVER_SSM_ARN}:TWITTER_CLIENT_SECRET::`,
           },
-          {
-            name: "FACEBOOK_APP_ID",
-            valueFrom: `${IAM_SERVER_SSM_ARN}:FACEBOOK_APP_ID::`,
-          },
-          {
-            name: "FACEBOOK_APP_SECRET",
-            valueFrom: `${IAM_SERVER_SSM_ARN}:FACEBOOK_APP_SECRET::`,
-          },
           {
             name: "BRIGHTID_PRIVATE_KEY",
             valueFrom: `${IAM_SERVER_SSM_ARN}:BRIGHTID_PRIVATE_KEY::`,

diff --git a/infra/staging/index.ts b/infra/staging/index.ts
@@ -214,14 +214,6 @@ const service = new awsx.ecs.FargateService("dpopp-iam", {
             name: "TWITTER_CLIENT_SECRET",
             valueFrom: `${IAM_SERVER_SSM_ARN}:TWITTER_CLIENT_SECRET::`,
           },
-          {
-            name: "FACEBOOK_APP_ID",
-            valueFrom: `${IAM_SERVER_SSM_ARN}:FACEBOOK_APP_ID::`,
-          },
-          {
-            name: "FACEBOOK_APP_SECRET",
-            valueFrom: `${IAM_SERVER_SSM_ARN}:FACEBOOK_APP_SECRET::`,
-          },
           {
             name: "BRIGHTID_PRIVATE_KEY",
             valueFrom: `${IAM_SERVER_SSM_ARN}:BRIGHTID_PRIVATE_KEY::`,

diff --git a/platforms/src/Facebook/App-Bindings.ts b/platforms/src/Facebook/App-Bindings.ts