fix: empty sni cause vmess parser to crash (Qv2ray#1448)

* fix: empty sni cause vmess parser to crash * chores: bumping build version
CedrusZhao · May 1, 2021 · e58e54b · e58e54b
1 parent 95245f9
commit e58e54b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/makespec/BUILDVERSION b/makespec/BUILDVERSION
@@ -1 +1 @@
-6201
+6203
diff --git a/src/core/connection/serialization/vmess.cpp b/src/core/connection/serialization/vmess.cpp
@@ -214,7 +214,6 @@ namespace Qv2ray::core::connection
                 __vmess_checker__func(tls, << "none"                                                                                    //
                                            << "tls");                                                                                   //
                                                                                                                                         //
-                __vmess_checker__func(sni, nothing);                                                                                    //
                 path = vmessConf.contains("path") ? vmessConf["path"].toVariant().toString() : (net == "quic" ? "" : "/");
                 host = vmessConf.contains("host") ? vmessConf["host"].toVariant().toString() : (net == "quic" ? "none" : "");
             }
@@ -288,8 +287,10 @@ namespace Qv2ray::core::connection
             }
 
             streaming.security = tls;
-            if (tls == "tls" && !sni.isEmpty())
+            if (tls == "tls")
             {
+                if (sni.isEmpty() && !host.isEmpty())
+                    sni = host;
                 streaming.tlsSettings.serverName = sni;
                 streaming.tlsSettings.allowInsecure = false;
             }