Fix bug where undefined Jinja variable in macro file crashes linter (s…

…qlfluff#3751)

Co-authored-by: Barry Hart <[email protected]>

src/sqlfluff/core/templaters/jinja.py

@@ -14,6 +14,7 @@
     meta,
 )
 from jinja2.environment import Template
+from jinja2.exceptions import UndefinedError
 from jinja2.sandbox import SandboxedEnvironment
 
 from sqlfluff.core.config import FluffConfig
@@ -57,11 +58,17 @@ def _extract_macros_from_template(template, env, ctx):
         context = {}
         macro_template = env.from_string(template, globals=ctx)
         # This is kind of low level and hacky but it works
-        for k in macro_template.module.__dict__:
-            attr = getattr(macro_template.module, k)
-            # Is it a macro? If so install it at the name of the macro
-            if isinstance(attr, Macro):
-                context[k] = attr
+        try:
+            for k in macro_template.module.__dict__:
+                attr = getattr(macro_template.module, k)
+                # Is it a macro? If so install it at the name of the macro
+                if isinstance(attr, Macro):
+                    context[k] = attr
+        except UndefinedError:
+            # This occurs if any file in the macro path references an
+            # undefined Jinja variable. It's safe to ignore this. Any
+            # meaningful issues will surface later at linting time.
+            pass
         # Return the context
         return context
 

test/fixtures/linter/autofix/ansi/macro_file_jinja_include_undefined_variable/.sqlfluff

@@ -0,0 +1,5 @@
+[sqlfluff]
+dialect = ansi
+
+[sqlfluff:templater:jinja]
+load_macros_from_path = test/fixtures/linter/autofix/ansi/macro_file_jinja_include_undefined_variable/macros

test/fixtures/linter/autofix/ansi/macro_file_jinja_include_undefined_variable/after.sql

@@ -0,0 +1,2 @@
+SELECT id
+FROM records

test/fixtures/linter/autofix/ansi/macro_file_jinja_include_undefined_variable/before.sql

@@ -0,0 +1,3 @@
+SELECT
+id
+FROM records

test/fixtures/linter/autofix/ansi/macro_file_jinja_include_undefined_variable/macros/utils.sql

@@ -0,0 +1 @@
+{% include sql_file %}

test/fixtures/linter/autofix/ansi/macro_file_jinja_include_undefined_variable/test-config.yml

@@ -0,0 +1,3 @@
+test-config:
+  rules:
+    - L036