rename: pure_c -> no_libstdcxx (f0rmiga#37)

* rename: pure_c -> no_libstdcxx This translates better the intention of the feature as there are other cases we may want to tweak this feature even when compiling C++. E.g. when linking against another libstdc++.so the user may want. Signed-off-by: Thulio Ferraz Assis <[email protected]> * fix: generated docs Signed-off-by: Thulio Ferraz Assis <[email protected]>
Checkmk · May 30, 2022 · 23609a8 · 23609a8
1 parent 4147afa
commit 23609a8
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 9 deletions.
diff --git a/docs/README.md b/docs/README.md
diff --git a/docs/defs.md b/docs/defs.md
diff --git a/examples/hello_world_c/BUILD.bazel b/examples/hello_world_c/BUILD.bazel
@@ -4,7 +4,7 @@ load("@bazel_tools//tools/build_defs/pkg:pkg.bzl", "pkg_tar")
 cc_binary(
     name = "hello_world_c",
     srcs = ["main.c"],
-    features = ["pure_c"],
+    features = ["no_libstdcxx"],
 )
 
 platform_transition_filegroup(

diff --git a/toolchain/cc_toolchain_config.bzl b/toolchain/cc_toolchain_config.bzl
@@ -83,7 +83,7 @@ def _impl(ctx):
         tools = [tool(path = objcopy_tool)],
     )
 
-    pure_c_feature = feature(name = "pure_c")
+    no_libstdcxx_feature = feature(name = "no_libstdcxx")
     static_libstdcxx_feature = feature(name = "static_libstdcxx")
 
     default_link_flags_feature = feature(
@@ -112,7 +112,7 @@ def _impl(ctx):
                 with_features = [
                     with_feature_set(
                         not_features = [
-                            "pure_c",
+                            "no_libstdcxx",
                             "static_libstdcxx",
                         ],
                     ),
@@ -127,7 +127,7 @@ def _impl(ctx):
                 ],
                 with_features = [
                     with_feature_set(
-                        not_features = ["pure_c"],
+                        not_features = ["no_libstdcxx"],
                         features = ["static_libstdcxx"],
                     ),
                 ],
@@ -388,7 +388,7 @@ def _impl(ctx):
         default_compile_flags_feature,
         include_paths_feature,
         library_search_directories_feature,
-        pure_c_feature,
+        no_libstdcxx_feature,
         static_libstdcxx_feature,
         default_link_flags_feature,
         supports_dynamic_linker_feature,

diff --git a/toolchain/defs.bzl b/toolchain/defs.bzl
@@ -146,7 +146,7 @@ _DOWNLOAD_TOOLCHAIN_ATTRS = {
 
 _FEATURE_ATTRS = {
     "bazel_gcc_toolchain_workspace_name": attr.string(
-        doc = "The name give to the repository when imported bazel_gcc_toolchain.",
+        doc = "The name given to the repository when imported bazel_gcc_toolchain.",
         default = "bazel_gcc_toolchain",
     ),
     "binary_prefix": attr.string(