Skip to content

Commit

Permalink
fix(local pub sub): use error for subscription cancelled (instead of …
Browse files Browse the repository at this point in the history
…info) (dymensionxyz#853)
  • Loading branch information
danwt authored May 14, 2024
1 parent 5a562ad commit 1886e18
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion block/synctarget.go
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ func (m *Manager) SyncTargetLoop(ctx context.Context) {
m.UpdateSyncParams(eventData.EndHeight)
m.SyncTargetDiode.Set(diodes.GenericDataType(&eventData.EndHeight))
case <-subscription.Cancelled():
m.logger.Info("syncTargetLoop subscription canceled")
m.logger.Error("syncTargetLoop subscription canceled")
return
}
}
Expand Down
2 changes: 1 addition & 1 deletion settlement/dymension/dymension.go
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ func (d *HubClient) PostBatch(batch *types.Batch, daClient da.Client, daResult *
return d.ctx.Err()

case <-subscription.Cancelled():
return fmt.Errorf("subscription cancelled: %w", err)
return fmt.Errorf("subscription cancelled")

case <-subscription.Out():
d.logger.Debug("Batch accepted", "startHeight", batch.StartHeight, "endHeight", batch.EndHeight)
Expand Down
2 changes: 1 addition & 1 deletion utils/event/funcs.go
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ func MustSubscribe(
case event := <-subscription.Out():
callback(event)
case <-subscription.Cancelled():
logger.Info(clientID + " subscription canceled")
logger.Error("subscription cancelled", "clientID", clientID)
return
}
}
Expand Down

0 comments on commit 1886e18

Please sign in to comment.