feat(fraud): extend fraud information upon detection (dymensionxyz#1237)

Co-authored-by: Faulty Tolly <@faulttolerance.net> Co-authored-by: unknown unknown <unknown@unknown> Co-authored-by: Sergi Rene <[email protected]> Co-authored-by: Sergi Rene <[email protected]> Co-authored-by: keruch <[email protected]> Co-authored-by: Daniel T <[email protected]> Co-authored-by: keruch <[email protected]>
ChengenH · Nov 19, 2024 · 377dc7c · 377dc7c
1 parent a5453ad
commit 377dc7c
Show file tree

Hide file tree

Showing 13 changed files with 193 additions and 74 deletions.
diff --git a/block/fork_test.go b/block/fork_test.go
@@ -99,7 +99,6 @@ func TestShouldStopNode(t *testing.T) {
 }
 
 func TestCheckForkUpdate(t *testing.T) {
-
 	tests := []struct {
 		name          string
 		setupMocks    func(*settlement.MockClientI, *store.MockStore, *types.State)

diff --git a/block/manager_test.go b/block/manager_test.go
@@ -21,6 +21,7 @@ import (
 	"github.com/dymensionxyz/dymint/testutil"
 	"github.com/dymensionxyz/dymint/types"
 	"github.com/dymensionxyz/dymint/types/pb/dymensionxyz/dymension/rollapp"
+	"github.com/dymensionxyz/dymint/version"
 
 	abci "github.com/tendermint/tendermint/abci/types"
 	"github.com/tendermint/tendermint/crypto/ed25519"
@@ -45,6 +46,7 @@ import (
 // TODO: test sequencer after L2 handover but before last state update submitted
 // TODO: test halt scenario
 func TestInitialState(t *testing.T) {
+	version.DRS = "0"
 	var err error
 	assert := assert.New(t)
 	genesis := testutil.GenerateGenesis(123)

diff --git a/block/production_test.go b/block/production_test.go
@@ -32,11 +32,13 @@ import (
 	"github.com/dymensionxyz/dymint/types"
 	uchannel "github.com/dymensionxyz/dymint/utils/channel"
 	uevent "github.com/dymensionxyz/dymint/utils/event"
+	"github.com/dymensionxyz/dymint/version"
 )
 
 // TODO: test producing lastBlock
 // TODO: test using already produced lastBlock
 func TestCreateEmptyBlocksEnableDisable(t *testing.T) {
+	version.DRS = "0"
 	const blockTime = 200 * time.Millisecond
 	const MaxIdleTime = blockTime * 10
 	const runTime = 10 * time.Second
@@ -292,6 +294,7 @@ func TestUpdateInitialSequencerSet(t *testing.T) {
 	require := require.New(t)
 	app := testutil.GetAppMock(testutil.EndBlock)
 	ctx := context.Background()
+	version.DRS = "0"
 	app.On("EndBlock", mock.Anything).Return(abci.ResponseEndBlock{
 		RollappParamUpdates: &abci.RollappParams{
 			Da:         "mock",
@@ -398,6 +401,7 @@ func TestUpdateExistingSequencerSet(t *testing.T) {
 	require := require.New(t)
 	app := testutil.GetAppMock(testutil.EndBlock)
 	ctx := context.Background()
+	version.DRS = "0"
 	app.On("EndBlock", mock.Anything).Return(abci.ResponseEndBlock{
 		RollappParamUpdates: &abci.RollappParams{
 			Da:         "mock",

diff --git a/block/slvalidator.go b/block/slvalidator.go
@@ -194,10 +194,7 @@ func (v *SettlementValidator) ValidateDaBlocks(slBatch *settlement.ResultRetriev
 	}
 
 	if !bytes.Equal(expectedNextSeqHash[:], lastDABlock.Header.NextSequencersHash[:]) {
-		return types.NewErrInvalidNextSequencersHashFraud(
-			expectedNextSeqHash,
-			lastDABlock.Header.NextSequencersHash,
-		)
+		return types.NewErrInvalidNextSequencersHashFraud(expectedNextSeqHash, lastDABlock.Header)
 	}
 
 	v.logger.Debug("DA blocks validated successfully", "start height", daBlocks[0].Header.Height, "end height", daBlocks[len(daBlocks)-1].Header.Height)

diff --git a/block/slvalidator_test.go b/block/slvalidator_test.go
@@ -18,6 +18,7 @@ import (
 	"github.com/dymensionxyz/dymint/testutil"
 	"github.com/dymensionxyz/dymint/types"
 	"github.com/dymensionxyz/dymint/types/pb/dymensionxyz/dymension/rollapp"
+	"github.com/dymensionxyz/dymint/version"
 	"github.com/libp2p/go-libp2p/core/crypto"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/mock"
@@ -29,6 +30,7 @@ import (
 )
 
 func TestStateUpdateValidator_ValidateStateUpdate(t *testing.T) {
+	version.DRS = "0"
 	// Init app
 	app := testutil.GetAppMock(testutil.EndBlock)
 	app.On("EndBlock", mock.Anything).Return(abci.ResponseEndBlock{

diff --git a/block/submit_test.go b/block/submit_test.go
@@ -26,6 +26,7 @@ import (
 	slmocks "github.com/dymensionxyz/dymint/mocks/github.com/dymensionxyz/dymint/settlement"
 	"github.com/dymensionxyz/dymint/testutil"
 	"github.com/dymensionxyz/dymint/types"
+	"github.com/dymensionxyz/dymint/version"
 )
 
 // TestBatchOverhead tests the scenario where we have a single block that is very large, and occupies the entire batch size.
@@ -34,6 +35,7 @@ import (
 // 1. single block with single large tx
 // 2. single block with multiple small tx
 func TestBatchOverhead(t *testing.T) {
+	version.DRS = "0"
 	manager, err := testutil.GetManager(testutil.GetManagerConfig(), nil, 1, 1, 0, nil, nil)
 	require.NoError(t, err)
 	require.NotNil(t, manager)
@@ -105,6 +107,8 @@ func TestBatchSubmissionHappyFlow(t *testing.T) {
 	app := testutil.GetAppMock(testutil.EndBlock)
 	ctx := context.Background()
 
+	version.DRS = "0"
+
 	// Create proxy app
 	clientCreator := proxy.NewLocalClientCreator(app)
 	proxyApp := proxy.NewAppConns(clientCreator)
@@ -149,6 +153,8 @@ func TestBatchSubmissionFailedSubmission(t *testing.T) {
 	app := testutil.GetAppMock(testutil.EndBlock)
 	ctx := context.Background()
 
+	version.DRS = "0"
+
 	app.On("EndBlock", mock.Anything).Return(abci.ResponseEndBlock{
 		RollappParamUpdates: &abci.RollappParams{
 			Da:         "mock",
@@ -222,6 +228,7 @@ func TestSubmissionByTime(t *testing.T) {
 		submitTimeout = 1 * time.Second
 		blockTime     = 200 * time.Millisecond
 	)
+	version.DRS = "0"
 
 	require := require.New(t)
 	app := testutil.GetAppMock(testutil.EndBlock)

diff --git a/node/node_test.go b/node/node_test.go
@@ -14,6 +14,7 @@ import (
 	"github.com/dymensionxyz/dymint/node"
 	"github.com/dymensionxyz/dymint/settlement"
 	"github.com/dymensionxyz/dymint/testutil"
+	"github.com/dymensionxyz/dymint/version"
 
 	"github.com/libp2p/go-libp2p/core/crypto"
 	"github.com/libp2p/go-libp2p/core/peer"
@@ -31,6 +32,7 @@ import (
 // simply check that node is starting and stopping without panicking
 func TestStartup(t *testing.T) {
 
+	version.DRS = "0"
 	assert := assert.New(t)
 	require := require.New(t)
 

diff --git a/p2p/block_sync_test.go b/p2p/block_sync_test.go
@@ -6,12 +6,14 @@ import (
 
 	"github.com/dymensionxyz/dymint/p2p"
 	"github.com/dymensionxyz/dymint/testutil"
+	"github.com/dymensionxyz/dymint/version"
 	"github.com/ipfs/go-datastore"
 	"github.com/stretchr/testify/require"
 	"github.com/tendermint/tendermint/libs/log"
 )
 
 func TestBlockSync(t *testing.T) {
+	version.DRS = "0"
 	logger := log.TestingLogger()
 	ctx := context.Background()
 

diff --git a/rpc/client/client_test.go b/rpc/client/client_test.go
@@ -37,6 +37,7 @@ import (
 	"github.com/dymensionxyz/dymint/settlement"
 	"github.com/dymensionxyz/dymint/testutil"
 	"github.com/dymensionxyz/dymint/types"
+	"github.com/dymensionxyz/dymint/version"
 )
 
 var expectedInfo = abci.ResponseInfo{
@@ -986,6 +987,7 @@ func getRPCAndNodeSequencer(t *testing.T) (*tmmocks.MockApplication, *client.Cli
 // getRPC returns a mock application and a new RPC client (non-sequencer mode)
 func getRPCInternal(t *testing.T, sequencer bool) (*tmmocks.MockApplication, *client.Client, *node.Node) {
 	t.Helper()
+	version.DRS = "0"
 	require := require.New(t)
 	app := &tmmocks.MockApplication{}
 	app.On("Info", mock.Anything).Return(expectedInfo)

diff --git a/rpc/rpc_test.go b/rpc/rpc_test.go
@@ -14,10 +14,12 @@ import (
 
 	"github.com/dymensionxyz/dymint/node/events"
 	"github.com/dymensionxyz/dymint/testutil"
+	"github.com/dymensionxyz/dymint/version"
 )
 
 func TestNodeHealthRPCPropagation(t *testing.T) {
 	var err error
+	version.DRS = "0"
 	server, listener := testutil.CreateLocalServer(t)
 	defer func() {
 		err = server.Stop()