Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test refactor and enhancement #1

Merged
merged 4 commits into from
Oct 3, 2014
Merged

Conversation

sroysf
Copy link
Contributor

@sroysf sroysf commented Sep 16, 2014

Refactored and cleaned up tests, modified to make them more reliable when executing from within a Java environment (such as IDE).

Also simplified some test coverage redundancy.

…when executed from within Java environments.
@@ -0,0 +1,80 @@
/*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, we really can't accept SF copyrighted stuff into here. We have an Apache license and even the test code has to be licensed as such.

@sroysf
Copy link
Contributor Author

sroysf commented Oct 3, 2014

Added the on-demand reading capability of stdout / stderr tails to previous pull request. Also modified it so that you can specify the number of lines you want (up to the maximum of 4000 lines) to retrieve.

That said, from a PO perspective, I am forced to wonder if this is actually useful. Perhaps what the implementation should really be is the ability to grab a given window. Basically, implement the less command pgup/pgdn functionality. That way, instead of a somewhat random window of data, the end user could actually use this interface (via JMX or otherwise) to elegantly scroll through the log files. Food for thought?

@sroysf
Copy link
Contributor Author

sroysf commented Oct 3, 2014

Also, buried in there is a subtle fix for an autoboxing problem that was leading to a very confusing NPE.

Hellblazer added a commit that referenced this pull request Oct 3, 2014
Test refactor and enhancement
@Hellblazer Hellblazer merged commit e2f5ba1 into ChiralBehaviors:master Oct 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants