Raise exception when ModifyVariable handler args incorrect, closes Sp…

…ongePowered#232
Chocohead · Jan 18, 2018 · 9a08917 · 9a08917
1 parent 569a0bc
commit 9a08917
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/src/main/java/org/spongepowered/asm/mixin/injection/modify/ModifyVariableInjector.java b/src/main/java/org/spongepowered/asm/mixin/injection/modify/ModifyVariableInjector.java
@@ -148,7 +148,13 @@ protected void inject(Target target, InjectionNode node) {
         if (this.discriminator.printLVT()) {
             this.printLocals(context);
         }
-
+
+        String handlerDesc = Bytecode.getDescriptor(new Type[] { this.returnType }, this.returnType);
+        if (!handlerDesc.equals(this.methodNode.desc)) {
+            throw new InvalidInjectionException(this.info, "Variable modifier " + this + " has an invalid signature, expected " + handlerDesc
+                    + " but found " + this.methodNode.desc);
+        }
+
         try {
             int local = this.discriminator.findLocal(context);
             if (local > -1) {