Skip to content

Commit

Permalink
Make linter image available on ECR when rebuilding (pytorch#96671)
Browse files Browse the repository at this point in the history
This is to fix the annoying error when lint jobs couldn't find the new image on ECR and fail.  They success once the image has been pushed there, for example https://github.com/pytorch/pytorch/actions/runs/4407785646/jobs/7722166975

### Testing

* Lint jobs successfully pull new linter image if there are changes to Docker https://github.com/pytorch/pytorch/actions/runs/4408362343
* No change to the Docker image. The existing one is pulled from ECR https://github.com/pytorch/pytorch/actions/runs/4408992880
* Remove `force_push` https://github.com/pytorch/pytorch/actions/runs/4410045959
* Retrying works fine https://github.com/pytorch/pytorch/actions/runs/4410045959/jobs/7727515932
Pull Request resolved: pytorch#96671
Approved by: https://github.com/malfet, https://github.com/seemethere
  • Loading branch information
huydhn authored and pytorchmergebot committed Mar 13, 2023
1 parent f330281 commit ae4d690
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions .github/workflows/_calculate-docker-image.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,3 +34,8 @@ jobs:
uses: ./.github/actions/calculate-docker-image
with:
docker-image-name: ${{ inputs.docker-image-name }}
# TODO: This flag is needed to make the Docker image available on ECR
# to avoid "Requested image not found" error for linter workflow. The
# longer term fix would be to refactor linter so that building the new
# image and running lint are done in the same runner like _linux-build
skip_push: false

0 comments on commit ae4d690

Please sign in to comment.