Criteria counts as table #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… logic and regenerated examples.
mgifford
approved these changes
Jul 20, 2023
dmundra
added a commit
that referenced
this pull request
Mar 12, 2024
…SA#354) * Drupal upgrade NextGen (#18) * Just the new drupal files * delete old acr * delete old acr * pre-commit fixes --------- Co-authored-by: pre-commit <[email protected]> * Updated html (#19) * Update drupal-10-16.yaml Changing the path to CivicActions. * Update drupal-10-16.html Using the CLI * Moving the 16 Simple * Adding Drupal 10 16 Simple * pre-commit fixes * Updated Drupal 10 yaml version. --------- Co-authored-by: pre-commit <[email protected]> Co-authored-by: Daniel Mundra <[email protected]> * Criteria counts as table (#20) * Redoing progressPerChapter to output counts as a table. * Removed skipping of none label. * Adjusted table counts per row display. * Added functions to get level and component labels to use in the progress table. * Updating markdown examples after testing. Reset output functions. * Changed any column header to all and added margin to simple table. * Removed un-needed conditional check. * Added check for undefined and updated all examples. * Added test when first criteria has missing components. Updated output logic and regenerated examples. * Updated tests. * Updated version and ran JS build. --------- Co-authored-by: Mike Gifford <[email protected]> Co-authored-by: pre-commit <[email protected]>
dmundra
added a commit
that referenced
this pull request
Mar 12, 2024
* Redoing progressPerChapter to output counts as a table. * Removed skipping of none label. * Adjusted table counts per row display. * Added functions to get level and component labels to use in the progress table. * Updating markdown examples after testing. Reset output functions. * Changed any column header to all and added margin to simple table. * Removed un-needed conditional check. * Added check for undefined and updated all examples. * Added test when first criteria has missing components. Updated output logic and regenerated examples. * Updated tests. * Updated version and ran JS build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing CivicActions/openacr-editor#23 in the CLI first. This took me a while as it was more complicated to count values into a table.
Testing steps: