Skip to content

Commit

Permalink
fix media comment url not showing
Browse files Browse the repository at this point in the history
closes EVAL-2327
flag=none

Test Plan:
1. Go to SpeedGrader and create a media comment.
2. Click to play the media comment, then click on the "CC" button and
   then click "Upload subtitles". In the modal that shows up, verify
   in the Step 1 section there is an input with a URL in it.
3. Click the "x" in the top-right corner of the modal. Then, click "CC"
   and "Upload subtitles" again. In the modal that shows up, verify
   in the Step 1 section there is an input with a URL in it.

Change-Id: Ia1fbe8c84adf4496ba2be5beb94ac48d9cac0dcc
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/293626
Tested-by: Service Cloud Jenkins <[email protected]>
Reviewed-by: Aaron Shafovaloff <[email protected]>
Reviewed-by: Eduardo Escobar <[email protected]>
QA-Review: Aaron Shafovaloff <[email protected]>
Product-Review: Jody Sailor
  • Loading branch information
spencerolson committed Jun 16, 2022
1 parent 4dacfb0 commit fd972d1
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions ui/shared/mediaelement/UploadMediaTrackForm.js
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ export default class UploadMediaTrackForm {
this.$dialog = $(template(templateVars))
.appendTo('body')
.dialog({
close: () => this.$dialog.remove(),
width: 650,
resizable: false,
buttons: [
Expand Down

0 comments on commit fd972d1

Please sign in to comment.