remove flag remove_gradebook_student_search_delay

closes EVAL-2565 flag=remove_gradebook_student_search_delay Test Plan: - specs pass Change-Id: Iaf901d89c5af221daa511d1780e1885d517f2636 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/298291 Tested-by: Service Cloud Jenkins <[email protected]> QA-Review: Spencer Olson <[email protected]> Product-Review: Spencer Olson <[email protected]> Reviewed-by: Kai Bjorkman <[email protected]> Reviewed-by: Eduardo Escobar <[email protected]>
CkReal · Aug 17, 2022 · fdefa1e · fdefa1e
1 parent 76fa864
commit fdefa1e
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 16 deletions.
diff --git a/app/controllers/gradebooks_controller.rb b/app/controllers/gradebooks_controller.rb
@@ -458,7 +458,6 @@ def set_default_gradebook_env
 
       publish_to_sis_url: context_url(@context, :context_details_url, anchor: "tab-grade-publishing"),
       re_upload_submissions_url: named_context_url(@context, :submissions_upload_context_gradebook_url, "{{ assignment_id }}"),
-      remove_gradebook_student_search_delay_enabled: Account.site_admin.feature_enabled?(:remove_gradebook_student_search_delay),
       reorder_custom_columns_url: api_v1_custom_gradebook_columns_reorder_url(@context),
       sections: sections_json(visible_sections, @current_user, session, [], allow_sis_ids: true),
       setting_update_url: api_v1_course_settings_url(@context),

diff --git a/config/feature_flags/apogee_release_flags.yml b/config/feature_flags/apogee_release_flags.yml
@@ -89,11 +89,6 @@ enhanced_gradebook_filters:
       this flag is enabled, early access to ongoing improvements will be displayed
       automatically with every release. For full details, please see the *Gradebook
       Filters User Group* in the Canvas Community.
-remove_gradebook_student_search_delay:
-  state: hidden
-  applies_to: SiteAdmin
-  display_name: Remove Delay for Gradebook Student Search
-  description: If set, removes the delay that normally occurs when searching for students.
 message_observers_of_students_who:
   state: hidden
   applies_to: SiteAdmin

diff --git a/spec/selenium/grades/gradebook/gradebook_spec.rb b/spec/selenium/grades/gradebook/gradebook_spec.rb
@@ -66,15 +66,6 @@
   end
 
   context "search" do
-    it "filters students without delay" do
-      Account.site_admin.enable_feature!(:remove_gradebook_student_search_delay)
-      Gradebook.visit(@course)
-      expect(Gradebook.fetch_student_names.size).to eq(@all_students.size)
-      f("#gradebook-student-search input").send_keys @course.students[0].name
-      f("#gradebook-student-search input").send_keys(:return)
-      expect(Gradebook.fetch_student_names).to match_array [@course.students[0].name]
-    end
-
     context "redesign" do
       before do
         Gradebook.visit(@course)

diff --git a/ui/features/gradebook/react/default_gradebook/gradebook.d.ts b/ui/features/gradebook/react/default_gradebook/gradebook.d.ts
@@ -83,7 +83,6 @@ export type GradebookOptions = {
   publish_to_sis_enabled: boolean
   publish_to_sis_url: string
   re_upload_submissions_url: string
-  remove_gradebook_student_search_delay_enabled: boolean
   reorder_custom_columns_url: string
   sections: Section[]
   setting_update_url: string