-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENHANCEMENT] Localization Support #3162
Open
j-gynn
wants to merge
69
commits into
ClanGenOfficial:development
Choose a base branch
from
j-gynn:ui-translation
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+25,354
−22,283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # resources/lang/en/patrols/general/border.json # scripts/utility.py
…edilla & a few others
# Conflicts: # resources/lang/en/events/relationship_events/normal_interactions/comfortable/increase.json # resources/lang/en/patrols/general/border.json
# Conflicts: # scripts/events_module/generate_events.py # tests/test_pronouns.py
# Conflicts: # resources/lang/en/patrols/general/border.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
(someone remind me to swap german off potatolang before this merges in pls)
Adds support to localize ClanGen. It's possible, by omitting files, to create a partial translation that uses English as a fallback. This allows for players to localise parts of the UI (or the whole thing) without having to create a whole bunch of events/patrols/thoughts/leader ceremonies/whatevers just to get the game rolling.
It has been explicitly designed so that content in other languages is unrelated to English. In other words, Patrol X in French might not exist in English at all. This is so that content does not have to simply be translations, but can be its own creative ventures in the target languages.
LIMITATIONS
Why This Is Good For ClanGen
Finally make the languages buttons on the settings screen do something ;)
Proof of Testing
Much testing will be required. Ideally, would love to ship with at least 1 additional language in the UI. For now, we run potatotests.
Changelog/Credits